From: nickcooper-zhangtonghao <nic@opencloud.tech>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA.
Date: Mon, 9 Jan 2017 10:14:12 +0800 [thread overview]
Message-ID: <36C737CB-D899-4969-8496-D6FC271752D4@opencloud.tech> (raw)
In-Reply-To: <20170105082633.48fc19df@xeon-e3>
Thanks for your reply. The patch you submitted is better. Thanks for your improvement.
My legal name is “Nick Zhang”. So,
Signed-off-by: Nick Zhang <nic@opencloud.tech>
Thanks.
Nick
> On Jan 6, 2017, at 12:26 AM, Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> It is good to see more checking for valid values. I suspect that other systems
> may have the same problem. My preference would to have the code comment generic
> and to have the precise details of about where this was observed in the commit
> log.
>
> The following would do same thing but be simpler:
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
> index 43501342..9f09cd98 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
> @@ -306,19 +306,12 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,
> dev->max_vfs = (uint16_t)tmp;
> }
>
> - /* get numa node */
> + /* get numa node, default to 0 if not present */
> snprintf(filename, sizeof(filename), "%s/numa_node",
> dirname);
> - if (access(filename, R_OK) != 0) {
> - /* if no NUMA support, set default to 0 */
> - dev->device.numa_node = 0;
> - } else {
> - if (eal_parse_sysfs_value(filename, &tmp) < 0) {
> - free(dev);
> - return -1;
> - }
> + if (eal_parse_sysfs_value(filename, &tmp) == 0 &&
> + tmp < RTE_MAX_NUMA_NODES)
> dev->device.numa_node = tmp;
> - }
>
> /* parse resources */
> snprintf(filename, sizeof(filename), "%s/resource", dirname);
prev parent reply other threads:[~2017-01-09 2:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 12:01 nickcooper-zhangtonghao
2017-01-05 12:01 ` [dpdk-dev] [PATCH v2 2/5] vmxnet3: Avoid memory leak in vmxnet3_dev_rx_queue_setup nickcooper-zhangtonghao
2017-01-05 12:01 ` [dpdk-dev] [PATCH v2 3/5] vmxnet3: Avoid segfault caused by vmxnet3_dev_rx_queue_setup nickcooper-zhangtonghao
2017-01-05 12:01 ` [dpdk-dev] [PATCH v2 4/5] vmxnet3: Avoid memory leak in vmxnet3_dev_tx_queue_setup nickcooper-zhangtonghao
2017-01-05 12:01 ` [dpdk-dev] [PATCH v2 5/5] vmxnet3: Avoid segfault caused by vmxnet3_dev_tx_queue_setup nickcooper-zhangtonghao
2017-01-05 14:23 ` [dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA Ferruh Yigit
2017-01-06 0:01 ` Yong Wang
2017-01-09 2:06 ` nickcooper-zhangtonghao
2017-01-09 2:20 ` nickcooper-zhangtonghao
2017-01-05 16:17 ` Stephen Hemminger
2017-01-05 16:26 ` Stephen Hemminger
2017-01-09 2:14 ` nickcooper-zhangtonghao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36C737CB-D899-4969-8496-D6FC271752D4@opencloud.tech \
--to=nic@opencloud.tech \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).