From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
David Marchand <david.marchand@redhat.com>,
dev@dpdk.org
Subject: Re: [PATCH] doc: remove confusing command to send patch
Date: Wed, 11 Oct 2023 12:20:41 +0200 [thread overview]
Message-ID: <3707040.MHq7AAxBmi@thomas> (raw)
In-Reply-To: <39af1d9d-e00d-4f61-b6e7-87490eb8e47f@amd.com>
11/10/2023 10:41, Ferruh Yigit:
> On 10/11/2023 9:30 AM, Bruce Richardson wrote:
> > On Wed, Oct 11, 2023 at 10:03:07AM +0200, Thomas Monjalon wrote:
> >> 11/10/2023 09:30, David Marchand:
> >>> On Tue, Oct 10, 2023 at 6:26 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >>>>
> >>>> In the contributor guide, it was said that no need to Cc maintainers
> >>>> for new additions, probably for new directories not having a maintainer.
> >>>> There is no harm, and it is a good habit, to always Cc maintainers.
> >>>>
> >>>> Remove this case as it can mislead to not Cc maintainers when needed.
> >>>>
> >>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >>>
> >>> I agree Cc: maintainers should be the default / recommended way of
> >>> sending patches.
> >>>
> >>> Just to convince myself, adding some meson skeleton for a "plop"
> >>> library, adding an entry in the release notes and hooking in
> >>> lib/meson.build:
> >>> $ git show --stat
> >>> doc/guides/rel_notes/release_23_11.rst | 4 ++++
> >>> lib/meson.build | 1 +
> >>> lib/plop/meson.build | 2 ++
> >>>
> >>> $ ./devtools/get-maintainer.sh 0001-new-awesome-library.patch
> >>>
> >>> In this case, it translates to an empty To: list if you follow the
> >>> example command line:
> >>> git send-email --to-cmd ./devtools/get-maintainer.sh --cc
> >>> dev@dpdk.org 000*.patch
> >>>
> >>> We could add a default list of recipients if no maintainer is found by
> >>> the script.
> >>> And the next question is who should be in that list..
> >>
> >> Or we can send to dev@dpdk.org, Cc maintainers.
> >> This is what I do:
> >> git send-email --to dev@dpdk.org --cc-cmd devtools/get-maintainer.sh
> >>
> > +1 for this, mainly on the basis of it being what I do too! :-)
> >
>
> I am for "--to-cmd=./devtools/get-maintainer.sh --cc dev@dpdk.org"
>
> To highlight response is expected from the maintainers, and community is
> informed.
>
> Also people may have filters to give higher priority to emails they are
> in 'to' list, high priority is what we want from maintainers :)
They should give high priority when they are Cc as well.
The problem is that we may have patches with empty "To",
especially for cover letters and new libs.
next prev parent reply other threads:[~2023-10-11 10:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 16:26 Thomas Monjalon
2023-10-11 2:04 ` fengchengwen
2023-10-11 7:30 ` David Marchand
2023-10-11 8:03 ` Thomas Monjalon
2023-10-11 8:30 ` Bruce Richardson
2023-10-11 8:41 ` Ferruh Yigit
2023-10-11 10:20 ` Thomas Monjalon [this message]
2023-10-11 10:22 ` Ferruh Yigit
2023-10-11 16:03 ` Thomas Monjalon
2023-10-11 15:52 ` Stephen Hemminger
2023-10-11 16:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3707040.MHq7AAxBmi@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).