From: Thomas Monjalon <thomas@monjalon.net>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, matan@mellanox.com,
keith.wiles@intel.com
Subject: Re: [dpdk-dev] [PATCH v3 2/2] test: update common auto test
Date: Wed, 04 Apr 2018 14:49:28 +0200 [thread overview]
Message-ID: <3820145.m9E1F7985g@xps> (raw)
In-Reply-To: <20180404101606.5156-2-pbhagavatula@caviumnetworks.com>
04/04/2018 12:16, Pavan Nikhilesh:
> Update common auto test to include test for previous power of 2 for both
> 32 and 64bit integers.
This patch can be merged with previous one (related lib change).
[...]
> + for (i = 1, p = 1; i <= MAX_NUM; i++) {
> + if (rte_align32prevpow2(i) != p)
> + FAIL_ALIGN("rte_align32prevpow2", i, p);
> + if (rte_is_power_of_2(i + 1))
> + p = i + 1;
> + }
> +
> + for (j = 1, q = 1; j <= MAX_NUM ; j++) {
> + if (rte_align64pow2(j) != q)
You could create FAIL_ALIGN64 for consistency.
> + printf("rte_align64pow2() test failed: %lu %lu\n", j,
%lu does not work on 32-bit machines.
Please use PRIu64.
See http://dpdk.org/ml/archives/dev/2018-February/090882.html
next prev parent reply other threads:[~2018-04-04 12:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-17 10:49 [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2 Pavan Nikhilesh
2018-02-17 10:49 ` [dpdk-dev] [PATCH 2/2] test: update common auto test Pavan Nikhilesh
2018-02-18 6:11 ` [dpdk-dev] [PATCH 1/2] eal: add API to align integer to previous power of 2 Matan Azrad
2018-02-18 15:39 ` Wiles, Keith
2018-02-19 6:03 ` Matan Azrad
2018-02-19 13:55 ` Wiles, Keith
2018-02-19 14:13 ` Matan Azrad
2018-02-19 14:21 ` Wiles, Keith
2018-02-19 16:18 ` Thomas Monjalon
2018-02-19 8:36 ` Pavan Nikhilesh
2018-02-19 11:36 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2018-02-19 11:36 ` [dpdk-dev] [PATCH v2 2/2] test: update common auto test Pavan Nikhilesh
2018-02-19 12:09 ` [dpdk-dev] [PATCH v2 1/2] eal: add API to align integer to previous power of 2 Matan Azrad
2018-02-26 19:10 ` Pavan Nikhilesh
2018-02-27 19:30 ` Matan Azrad
2018-04-04 10:16 ` [dpdk-dev] [PATCH v3 " Pavan Nikhilesh
2018-04-04 10:16 ` [dpdk-dev] [PATCH v3 2/2] test: update common auto test Pavan Nikhilesh
2018-04-04 12:49 ` Thomas Monjalon [this message]
2018-04-04 12:54 ` Pavan Nikhilesh
2018-04-04 16:10 ` [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2 Matan Azrad
2018-04-04 16:42 ` Pavan Nikhilesh
2018-04-04 17:11 ` Matan Azrad
2018-04-04 17:51 ` Pavan Nikhilesh
2018-04-04 18:10 ` Matan Azrad
2018-04-04 18:15 ` Pavan Nikhilesh
2018-04-04 18:23 ` Matan Azrad
2018-04-04 18:36 ` Pavan Nikhilesh
2018-04-04 19:41 ` Matan Azrad
2018-04-04 13:20 ` [dpdk-dev] [PATCH v4] " Pavan Nikhilesh
2018-04-04 15:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3820145.m9E1F7985g@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=keith.wiles@intel.com \
--cc=matan@mellanox.com \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).