DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>
Cc: "Iremonger, Bernard" <bernard.iremonger@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/test: fix bond device name too long
Date: Wed, 08 Jun 2016 15:31:05 +0200	[thread overview]
Message-ID: <3883347.3dLukHgfgL@xps13> (raw)
In-Reply-To: <60ABE07DBB3A454EB7FAD707B4BB158213AA771C@IRSMSX109.ger.corp.intel.com>

2016-06-08 11:50, Jastrzebski, MichalX K:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2016-05-27 18:38, Thomas Monjalon:
> > > 2016-05-27 17:20, Michal Jastrzebski:
> > > > Bond device name was too long (grather than 32 signs) that
> > > > cause mempool allocation to fail.
> > >
> > > Maybe that this kind of failure would be avoided if the test
> > > was added to autotests (app/test/autotest_data.py).
> > >
> > > Generally speaking, it would be a good idea to make an audit
> > > on which tests are missing in "make fast_test" and "make test".
> > 
> > Any comment please?
> 
> Hi Thomas,
> 
> There is a small timeout in test_tlb_tx_burst - big burst has to be generated to
> detect balancing and small timeout has to be included between each burst, 
> thus I am not sure if link_bonding_autotest can be classified to fast tests 
> (test takes about 3-4 seconds).
> We can add this test to autotests script for which time is not so critical.

The bug we see here could be detected by just initializing bonding.
Maybe we can consider having some basic/fast tests and others longer.

  reply	other threads:[~2016-06-08 13:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-27 15:20 Michal Jastrzebski
2016-05-27 15:20 ` [dpdk-dev] [PATCH] bond: replace rte_panic with errno code return Michal Jastrzebski
2016-05-27 16:13   ` Iremonger, Bernard
2016-06-13 13:57     ` Bruce Richardson
2016-05-27 16:14 ` [dpdk-dev] [PATCH] app/test: fix bond device name too long Iremonger, Bernard
2016-06-13 20:14   ` Thomas Monjalon
2016-05-27 16:38 ` Thomas Monjalon
2016-06-08 10:40   ` Thomas Monjalon
2016-06-08 11:50     ` Jastrzebski, MichalX K
2016-06-08 13:31       ` Thomas Monjalon [this message]
2016-06-08 14:27         ` Jastrzebski, MichalX K
2016-06-01  1:29 ` Xu, HuilongX
2016-06-01  3:25 ` Xu, HuilongX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3883347.3dLukHgfgL@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=michalx.k.jastrzebski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).