From: Thomas Monjalon <thomas@monjalon.net>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: dev@dpdk.org, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix trimming SW ring for vectorized Rx
Date: Thu, 03 Aug 2017 23:20:52 +0200 [thread overview]
Message-ID: <3890701.xl1HzoHyJz@xps> (raw)
In-Reply-To: <20170803211240.42742-1-yskoh@mellanox.com>
03/08/2017 23:12, Yongseok Koh:
> Unlike mlx5_rx_burst(), mlx5_rx_burst_vec() doesn't replace completed
> buffers one by one right after completion is processed but replenishes
> multiple buffers later with rte_mempool_get_bulk(). Therefore, there could
> be some buffer addresses left in the SW ring (rxq->elts[]) which have
> already been delivered to application. As PMD doesn't own such buffers, it
> must not be freed by PMD. "Trimming" is needed before cleanup.
>
> A problem can be seen when quitting testpmd when
> CONFIG_RTE_LIBRTE_MBUF_DEBUG=y and CONFIG_RTE_LIBRTE_MEMPOOL_DEBUG=y
>
> Trimming should be as simple as possible, it shouldn't touch any indexes
> and buffer allocation isn't necessary.
>
> Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86")
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied, thanks
prev parent reply other threads:[~2017-08-03 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 21:12 Yongseok Koh
2017-08-03 21:20 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3890701.xl1HzoHyJz@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).