From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"Mrozowicz, SlawomirX" <slawomirx.mrozowicz@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] examples/qos_sched: fix bad bit shift operation
Date: Mon, 16 May 2016 18:34:10 +0200 [thread overview]
Message-ID: <3903086.2L5T4XfrGH@xps13> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126479BB334@IRSMSX108.ger.corp.intel.com>
> > Subject: [PATCH v4] examples/qos_sched: fix bad bit shift operation
Slawomir, please use --in-reply-to when sending a new revision,
to let us see the full history in our mailer and in the archives.
[...]
> > diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
> > index 3e7fd08..354372d 100644
> > --- a/examples/qos_sched/args.c
> > +++ b/examples/qos_sched/args.c
> > @@ -123,7 +123,7 @@ app_eal_core_mask(void)
> > uint64_t cm = 0;
> > struct rte_config *cfg = rte_eal_get_configuration();
> >
> > - for (i = 0; i < RTE_MAX_LCORE; i++) {
> > + for (i = 0; i < APP_MAX_LCORE; i++) {
> > if (cfg->lcore_role[i] == ROLE_RTE)
> > cm |= (1ULL << i);
> > }
> > @@ -142,7 +142,7 @@ app_cpu_core_count(void)
> > char path[PATH_MAX];
> > uint32_t ncores = 0;
> >
> > - for(i = 0; i < RTE_MAX_LCORE; i++) {
> > + for (i = 0; i < APP_MAX_LCORE; i++) {
> > len = snprintf(path, sizeof(path), SYS_CPU_DIR, i);
> > if (len <= 0 || (unsigned)len >= sizeof(path))
> > continue;
> > diff --git a/examples/qos_sched/main.h b/examples/qos_sched/main.h
> > index 82aa0fa..c7490c6 100644
> > --- a/examples/qos_sched/main.h
> > +++ b/examples/qos_sched/main.h
> > @@ -68,7 +68,10 @@ extern "C" {
> >
> > #define BURST_TX_DRAIN_US 100
> >
> > -#define MAX_DATA_STREAMS (RTE_MAX_LCORE/2)
> > +#ifndef APP_MAX_LCORE
> > +#define APP_MAX_LCORE 64
> > +#endif
> > +#define MAX_DATA_STREAMS (APP_MAX_LCORE/2)
> > #define MAX_SCHED_SUBPORTS 8
> > #define MAX_SCHED_PIPES 4096
> >
> > --
> > 1.9.1
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cristian, please remove patch content when acking.
My hand is tired of scrolling ;)
next prev parent reply other threads:[~2016-05-16 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 8:48 Slawomir Mrozowicz
2016-05-11 10:17 ` Dumitrescu, Cristian
2016-05-16 16:34 ` Thomas Monjalon [this message]
2016-05-16 16:39 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3903086.2L5T4XfrGH@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=slawomirx.mrozowicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).