DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2] build: set rte toolchain macros from predefined macros
Date: Mon, 19 Feb 2024 02:51:24 +0100	[thread overview]
Message-ID: <3905014.ECZNHGQPT7@thomas> (raw)
In-Reply-To: <ZZvaGpHuI13NNhnt@bricha3-MOBL.ger.corp.intel.com>

08/01/2024 12:18, Bruce Richardson:
> On Tue, Jan 02, 2024 at 04:11:15PM -0800, Tyler Retzlaff wrote:
> > Stop writing RTE_TOOLCHAIN_XXX macros to rte_build_config.h. When an
> > application builds it doesn't necessarily use the same toolchain that
> > DPDK was built with.
> > 
> > Instead evaluate toolchain predefined macros and define
> > RTE_TOOLCHAIN_XXX macros as appropriate each time rte_config.h is
> > preprocessed.
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> 
> I don't see an issue with doing this.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.




      reply	other threads:[~2024-02-19  1:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-02 23:27 [PATCH] " Tyler Retzlaff
2024-01-03  0:11 ` [PATCH v2] " Tyler Retzlaff
2024-01-08 11:18   ` Bruce Richardson
2024-02-19  1:51     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3905014.ECZNHGQPT7@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=roretzla@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).