From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, wenzhuo.lu@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix compilation when vector driver disabled
Date: Mon, 16 Apr 2018 18:57:55 +0200 [thread overview]
Message-ID: <3918223.XbEGDHI6z0@xps> (raw)
In-Reply-To: <20180416133911.289196-1-bruce.richardson@intel.com>
16/04/2018 15:39, Bruce Richardson:
> The new functions for Rx and Tx offloads should not be inside the
> conditional block for the vector driver, otherwise compile errors occur
> when vector driver is disabled. For example:
>
> ixgbe_ethdev.c:3636:36: error: implicit declaration of function ‘ixgbe_get_rx_queue_offloads’;
>
> This shows up as an error when doing ARM builds using meson as the vector
> driver is not (yet) enabled for those builds.
>
> Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API")
> Fixes: ec3b1124d14d ("net/ixgbe: convert to new Rx offloads API")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-04-16 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 13:39 Bruce Richardson
2018-04-16 16:56 ` Thomas Monjalon
2018-04-16 16:57 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3918223.XbEGDHI6z0@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).