From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ouyang Changchun <changchun.ouyang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: Disable GCC warning on IXGBE base codes
Date: Fri, 10 Oct 2014 18:04:59 +0200 [thread overview]
Message-ID: <3936396.9kzqsUDoQ1@xps13> (raw)
In-Reply-To: <1412839679-8242-1-git-send-email-changchun.ouyang@intel.com>
2014-10-09 15:27, Ouyang Changchun:
> This patch disables compilation complain from lower GCC version (less than 4.6).
>
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> --- a/lib/librte_pmd_ixgbe/Makefile
> +++ b/lib/librte_pmd_ixgbe/Makefile
> @@ -66,6 +66,11 @@ ifeq ($(shell test $(GCC_MAJOR_VERSION) -ge 4 -a $(GCC_MINOR_VERSION) -ge 6 && e
> CFLAGS_ixgbe_common.o += -Wno-unused-but-set-variable
> CFLAGS_ixgbe_x550.o += -Wno-unused-but-set-variable -Wno-maybe-uninitialized
> endif
> +
> +ifeq ($(shell test $(GCC_MAJOR_VERSION) -le 4 -a $(GCC_MINOR_VERSION) -le 6 && echo 1), 1)
> +CFLAGS_ixgbe_x550.o += -Wno-uninitialized
> +CFLAGS_ixgbe_phy.o += -Wno-uninitialized
> +endif
> endif
Note that the tests in this file are valids only because we don't support
GCC 3 and there is no GCC 5 yet.
But I feel we should fix it soon.
Applied
Thanks
--
Thomas
prev parent reply other threads:[~2014-10-10 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 7:27 Ouyang Changchun
2014-10-10 16:04 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3936396.9kzqsUDoQ1@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).