From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mk: pass EXTRA_CFLAGS to AUTO_CPUFLAGS to enable local modifications
Date: Mon, 07 Dec 2015 12:47:53 +0100 [thread overview]
Message-ID: <3959911.rhgNy1YhGd@xps13> (raw)
In-Reply-To: <56654454.3040508@redhat.com>
2015-12-07 10:33, Panu Matilainen:
> On 12/04/2015 08:53 PM, Thomas Monjalon wrote:
> >>>> We have encountered a CPU where the AES-NI instruction set is disabled
> >>>> due to export restrictions. Since the build machine and target machine
> >>>> is different, using -native configs doesn't work, and on this CPU, the
> >>>> application refuses to run due to the AES CPU flags being amiss.
> >>>>
> >>>> The patch passes EXTRA_CFLAGS to the figure-out-cpu-flags helper,
> >>>> which allows us to add -mno-aes to the compile flags and resolve this
> >>>> problem.
> >>>>
> >>>> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> >>
> >> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> >
> > Applied, thanks
> >
>
> This causes some complications on Fedora/RHEL due to fairly complex
> interactions with -Werror, -Wall and -Wformat-security mixup between
> upstream- and distro default compiler flags.
>
> More specifically, when EXTRA_CFLAGS contains warning flag manipulation
> this patch can cause mismatch between other options that are okay
> elsewhere in dpdk make. A simple fix is to pass WERROR_FLAGS to
> AUTO_CPUFLAGS too to counter this, ie
>
> diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk
> index c6bb8de..28f203b 100644
> --- a/mk/rte.cpuflags.mk
> +++ b/mk/rte.cpuflags.mk
> @@ -33,7 +33,7 @@
> # used to set the RTE_CPUFLAG_* environment variables giving details
> # of what instruction sets the target cpu supports.
>
> -AUTO_CPUFLAGS := $(shell $(CC) $(MACHINE_CFLAGS) $(EXTRA_CFLAGS) -dM -E
> - < /dev/null)
> +AUTO_CPUFLAGS := $(shell $(CC) $(MACHINE_CFLAGS) $(WERROR_FLAGS)
> $(EXTRA_CFLAGS) -dM -E - < /dev/null)
>
> # adding flags to CPUFLAGS
>
>
> I can send an official patch if this seems acceptable.
Yes this is acceptable.
Please explain the error you see in the commit message.
prev parent reply other threads:[~2015-12-07 11:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 7:50 Simon Kagstrom
2015-12-04 8:12 ` Simon Kågström
2015-12-04 10:15 ` Olivier MATZ
2015-12-04 18:53 ` Thomas Monjalon
2015-12-07 8:33 ` Panu Matilainen
2015-12-07 11:47 ` Simon Kågström
2015-12-07 11:47 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3959911.rhgNy1YhGd@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).