DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ray Kinsella <mdr@ashroe.eu>,
	Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, david.marchand@redhat.com, techboard@dpdk.org,
	David Christensen <drc@linux.vnet.ibm.com>
Subject: Re: [PATCH] eal/ppc: undefine AltiVec keyword vector
Date: Thu, 26 May 2022 12:18:59 +0200	[thread overview]
Message-ID: <3966769.zXnORWrf4K@thomas> (raw)
In-Reply-To: <20220525183459.GA24690@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>

25/05/2022 20:34, Tyler Retzlaff:
> On Wed, May 25, 2022 at 07:02:52PM +0100, Ray Kinsella wrote:
> > Thomas Monjalon <thomas@monjalon.net> writes:
> > > 25/05/2022 13:48, Ray Kinsella:
> > >> Thomas Monjalon <thomas@monjalon.net> writes:
> > >> 
> > >> > The AltiVec header file is defining "vector", except in C++ build.
> > >> > The keyword "vector" may conflict easily.
> > >> > As a rule, it is better to use the alternative keyword "__vector".
> > >> >
> > >> > The DPDK header file rte_altivec.h takes care of undefining "vector",
> > >> > so the applications and dependencies are free to define the name "vector".
> > >> >
> > >> > This is a compatibility breakage for applications which were using
> > >> > the keyword "vector" for its AltiVec meaning.
> > >> >
> > >> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > >> > ---
> > >> >  doc/guides/rel_notes/release_22_07.rst | 5 +++++
> > >> >  lib/eal/ppc/include/rte_altivec.h      | 7 +++++++
> > >> >  2 files changed, 12 insertions(+)
> > >> >
> > >> 
> > >> Acked-by: Ray Kinsella <mdr@ashroe.eu>
> > >
> > > Just to make sure, we are all OK to break compatibility of rte_altivec.h?
> > > It means the keyword vector is not available anymore with this #include.
> > > Please confirm it is OK to merge in DPDK 22.07.
> > 
> > I did think about it yes ;-).
> > I can't see how it would break the ABI in the short term.
> > And it makes sense to preclude this keyword in the long term.
> > 
> > So I ack'ed - did I miss something?
> 
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> 
> double ack, impact of break is understood as follows.
> 
> * this is not an issue with abi it is an issue with api.
> * the break will cause a compile failure, the action to resolve is to
>   replace vector with __vector.

Exactly

I'll wait few days or acks from the techboard, and will apply.



  reply	other threads:[~2022-05-26 10:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25  9:53 Thomas Monjalon
2022-05-25 10:01 ` Tyler Retzlaff
2022-05-25 11:08 ` Ali Alnubani
2022-05-25 11:10   ` Ali Alnubani
2022-05-25 11:48 ` Ray Kinsella
2022-05-25 15:40   ` Thomas Monjalon
2022-05-25 18:02     ` Ray Kinsella
2022-05-25 18:34       ` Tyler Retzlaff
2022-05-26 10:18         ` Thomas Monjalon [this message]
2022-05-26 11:02           ` Ray Kinsella
2022-06-01 15:04             ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3966769.zXnORWrf4K@thomas \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=drc@linux.vnet.ibm.com \
    --cc=mdr@ashroe.eu \
    --cc=roretzla@linux.microsoft.com \
    --cc=techboard@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).