From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
dev@dpdk.org
Cc: "Keith Wiles" <keith.wiles@intel.com>,
"Hongzhi Guo" <guohongzhi1@huawei.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Thomas Monjalon" <thomas@monjalon.net>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/4] net/tap: fix Rx cksum flags on IP options packets
Date: Tue, 8 Jun 2021 13:13:59 +0300 [thread overview]
Message-ID: <39a8a8bb-d246-3377-607c-3c2387b73fe0@oktetlabs.ru> (raw)
In-Reply-To: <5fa9bc52-0862-983e-3e38-33a937872571@intel.com>
On 4/30/21 5:48 PM, Ferruh Yigit wrote:
> On 4/27/2021 2:57 PM, Olivier Matz wrote:
>> When packet type is IPV4_EXT, the checksum is always marked as good in
>> the mbuf offload flags.
>>
>> Since we know the header lengths, we can easily call
>> rte_ipv4_udptcp_cksum() in this case too.
>>
>> Fixes: 8ae3023387e9 ("net/tap: add Rx/Tx checksum offload support")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>> ---
>> drivers/net/tap/rte_eth_tap.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
>> index 68baa18523..e7b185a4b5 100644
>> --- a/drivers/net/tap/rte_eth_tap.c
>> +++ b/drivers/net/tap/rte_eth_tap.c
>> @@ -350,7 +350,7 @@ tap_verify_csum(struct rte_mbuf *mbuf)
>> /* Don't verify checksum for multi-segment packets. */
>> if (mbuf->nb_segs > 1)
>> return;
>> - if (l3 == RTE_PTYPE_L3_IPV4) {
>> + if (l3 == RTE_PTYPE_L3_IPV4 || l3 == RTE_PTYPE_L3_IPV4_EXT) {
>
> Should we take 'RTE_PTYPE_L3_IPV4_EXT_UNKNOWN' into account?
I think we should.
>
>> if (l4 == RTE_PTYPE_L4_UDP) {
>> udp_hdr = (struct rte_udp_hdr *)l4_hdr;
>> if (udp_hdr->dgram_cksum == 0) {
>> @@ -364,7 +364,7 @@ tap_verify_csum(struct rte_mbuf *mbuf)
>> }
>> }
>> cksum = ~rte_ipv4_udptcp_cksum(l3_hdr, l4_hdr);
>> - } else if (l3 == RTE_PTYPE_L3_IPV6) {
>> + } else { /* l3 == RTE_PTYPE_L3_IPV6, checked above */
>> cksum = ~rte_ipv6_udptcp_cksum(l3_hdr, l4_hdr);
>> }
>> mbuf->ol_flags |= cksum ?
>>
next prev parent reply other threads:[~2021-06-08 10:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210427135755.927-1-olivier.matz@6wind.com>
2021-04-27 13:57 ` [dpdk-stable] " Olivier Matz
2021-04-30 14:48 ` Ferruh Yigit
2021-06-08 10:13 ` Andrew Rybchenko [this message]
2021-06-08 12:29 ` [dpdk-stable] [dpdk-dev] " Olivier Matz
2021-06-08 12:34 ` Andrew Rybchenko
2021-06-08 12:49 ` Olivier Matz
2021-06-08 13:57 ` Andrew Rybchenko
2021-06-08 14:30 ` Olivier Matz
2021-04-27 13:57 ` [dpdk-stable] [PATCH 2/4] net/tap: fix Rx cksum flags on TCP packets Olivier Matz
2021-06-08 10:18 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
[not found] ` <20210630135158.8108-1-olivier.matz@6wind.com>
2021-06-30 13:51 ` [dpdk-stable] [PATCH v2 1/4] net/tap: fix Rx cksum flags on IP options packets Olivier Matz
2021-06-30 13:51 ` [dpdk-stable] [PATCH v2 2/4] net/tap: fix Rx cksum flags on TCP packets Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39a8a8bb-d246-3377-607c-3c2387b73fe0@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=guohongzhi1@huawei.com \
--cc=keith.wiles@intel.com \
--cc=mb@smartsharesystems.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).