From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Horton, Remy" <remy.horton@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] latencystats: added new library for latency stats
Date: Fri, 11 Nov 2016 11:15:54 +0000 [thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F010C3821@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <5b715ac1-b9e8-f7fc-33a1-a430208c4fe4@intel.com>
Hi
> -----Original Message-----
> From: Horton, Remy
> Sent: Friday, November 11, 2016 2:22 AM
> To: Pattan, Reshma <reshma.pattan@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4] latencystats: added new library for
> latency stats
>
>
> On 07/11/2016 21:14, Reshma Pattan wrote:
> [..]
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
>
> Reviewed-by: Remy Horton <remy.horton@intel.com>
>
>
> > +static void
> > +metrics_display(int port_id)
> > +{
> > + struct rte_stat_value *stats;
> > + struct rte_metric_name *names;
>
> Note that rte_stats_value is being renamed to rte_metric_value in the next
> version of the metrics library..
>
Ok.
>
> > +int
> > +rte_latencystats_init(uint64_t samp_intvl,
> > + rte_latency_stats_flow_type_fn user_cb)
> > +{
>
> Far as I can tell, user_cb is always NULL, and the two callbacks it
> eventually get passed to don't use it. There any reason the function
> signature has it at all?
>
Yes, with the possibility of getting flow based latency stats requiments in future, user callback is added to signature.
With this user callback, it is up to the application to identify the flow type and return the flow type. Library will maintain latency calculation per flow type
in a separate table. Basically for future enhancement.
>
> > +++ b/lib/librte_latencystats/rte_latencystats_version.map
> > @@ -0,0 +1,10 @@
> > +DPDK_16.11 {
>
> This will need to change to 17.02 once new release cycle starts. :)
>
> Will also need to add entry to release_17_02.rst once it becomes available..
>
Ok.
Thanks,
Reshma
next prev parent reply other threads:[~2016-11-11 11:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 16:39 [dpdk-dev] [RFC] " Reshma Pattan
2016-10-07 16:10 ` [dpdk-dev] [RFC v2] " Reshma Pattan
2016-10-17 13:39 ` [dpdk-dev] [RFC v3] " Reshma Pattan
2016-10-18 10:44 ` Pattan, Reshma
2016-11-07 13:14 ` [dpdk-dev] [PATCH v4] " Reshma Pattan
2016-11-08 12:34 ` Pattan, Reshma
2016-11-11 2:22 ` Remy Horton
2016-11-11 11:15 ` Pattan, Reshma [this message]
2016-11-15 13:37 ` [dpdk-dev] [PATCH v5] " Reshma Pattan
2016-11-18 6:17 ` Remy Horton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEA2BF9852C6F48A459DA490692831F010C3821@IRSMSX109.ger.corp.intel.com \
--to=reshma.pattan@intel.com \
--cc=dev@dpdk.org \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).