From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Horton, Remy" <remy.horton@intel.com>,
"Chaitanya Babu, TalluriX" <tallurix.chaitanya.babu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] add sample functions for packet forwarding
Date: Tue, 10 Jul 2018 09:53:48 +0000 [thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A36D1AD@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <1530896835-19629-1-git-send-email-jananeex.m.parthasarathy@intel.com>
Hi Jananee,
> -----Original Message-----
> From: Parthasarathy, JananeeX M
> Sent: Friday, July 6, 2018 6:07 PM
> To: dev@dpdk.org
> Cc: Horton, Remy <remy.horton@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>; Parthasarathy, JananeeX M
> <jananeex.m.parthasarathy@intel.com>; Chaitanya Babu, TalluriX
> <tallurix.chaitanya.babu@intel.com>
> Subject: [PATCH] add sample functions for packet forwarding
>
> From: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
>
> Add sample test functions for packet forwarding.
> These can be used for unit test cases for LatencyStats and BitrateStats
> libraries.
>
> Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> a/test/test/sample_packet_forward.c b/test/test/sample_packet_forward.c
> new file mode 100644
> index 000000000..6f66b83f8
> --- /dev/null
> +++ b/test/test/sample_packet_forward.c
> @@ -0,0 +1,80 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2018 Intel Corporation
> + */
> +int
> +test_ring_setup(void)
> +{
> + uint16_t socket_id = rte_socket_id();
> + rxtx[1] = rte_ring_create("R1", RING_SIZE, socket_id,
> + RING_F_SP_ENQ|RING_F_SC_DEQ);
> + if (rxtx[1] == NULL) {
> + printf("%s() line %u: rte_ring_create R1 failed",
> + __func__, __LINE__);
> + return TEST_FAILED;
> + }
> + tx_portid = rte_eth_from_rings("net_ringa", rxtx, NUM_RINGS, rxtx,
> + NUM_RINGS, SOCKET0);
> + rx_portid = rte_eth_from_rings("net_ringb", rxtx, NUM_RINGS, rxtx,
> + NUM_RINGS, SOCKET0);
> +
Here also socket_id should be used, so u can remove SOCKET0 and its macro.
> diff --git a/test/test/sample_packet_forward.h
> b/test/test/sample_packet_forward.h
#define SOCKET0 0
This can be removed now as rte_socke_id() is used now.
#define
> +RING_SIZE 256 #define NUM_RINGS 2
Instead of NUM_RINGS, you can name it as NUM_QUEUES.
You can have this value as 1, as you are using only 1 queue anyway in *tx_burst and rx_burst.
Thanks,
Reshma
next prev parent reply other threads:[~2018-07-10 9:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 17:07 Jananee Parthasarathy
2018-07-10 9:53 ` Pattan, Reshma [this message]
2018-07-12 8:53 ` [dpdk-dev] [PATCH v2] " Jananee Parthasarathy
2018-07-12 16:00 ` Pattan, Reshma
2018-07-16 16:00 ` [dpdk-dev] [PATCH v3] test: " Jananee Parthasarathy
2018-07-17 8:15 ` Pattan, Reshma
2018-07-17 10:00 ` [dpdk-dev] [PATCH v4] " Jananee Parthasarathy
2018-07-17 10:22 ` Burakov, Anatoly
2018-07-24 10:54 ` [dpdk-dev] [PATCH v5 0/4] add unit tests for bitrate, latency and pdump libraries Naga Suresh Somarowthu
2018-07-24 10:54 ` [dpdk-dev] [PATCH v5 1/4] test: add ring pmd based packet rx/tx for UT Naga Suresh Somarowthu
2018-07-24 11:21 ` Burakov, Anatoly
2018-07-24 10:54 ` [dpdk-dev] [PATCH v5 2/4] test: add unit tests for bitrate library Naga Suresh Somarowthu
2018-07-24 10:54 ` [dpdk-dev] [PATCH v5 3/4] test: add unit tests for latencystats library Naga Suresh Somarowthu
2018-07-24 10:54 ` [dpdk-dev] [PATCH v5 4/4] test: add unit test for pdump library Naga Suresh Somarowthu
2018-07-24 12:27 ` Burakov, Anatoly
2018-07-25 17:05 ` [dpdk-dev] [PATCH v6 0/4] add unit tests for bitrate, latency and pdump libraries Naga Suresh Somarowthu
2018-07-25 17:05 ` [dpdk-dev] [PATCH v6 1/4] test: add ring pmd based packet rx/tx for UT Naga Suresh Somarowthu
2018-07-26 9:59 ` Burakov, Anatoly
2018-07-25 17:05 ` [dpdk-dev] [PATCH v6 2/4] test: add unit tests for bitrate library Naga Suresh Somarowthu
2018-07-25 17:05 ` [dpdk-dev] [PATCH v6 3/4] test: add unit tests for latencystats library Naga Suresh Somarowthu
2018-07-25 17:06 ` [dpdk-dev] [PATCH v6 4/4] test: add unit test for pdump library Naga Suresh Somarowthu
2018-07-26 10:02 ` Burakov, Anatoly
2018-07-26 12:50 ` [dpdk-dev] [PATCH v7 0/4] add unit tests for bitrate, latency and pdump libraries Naga Suresh Somarowthu
2018-07-26 12:50 ` [dpdk-dev] [PATCH v7 1/4] test: add ring pmd based packet rx/tx for UT Naga Suresh Somarowthu
2018-07-26 16:43 ` Pattan, Reshma
2018-07-27 7:40 ` Burakov, Anatoly
2018-07-26 12:50 ` [dpdk-dev] [PATCH v7 2/4] test: add unit tests for bitrate library Naga Suresh Somarowthu
2018-07-26 12:50 ` [dpdk-dev] [PATCH v7 3/4] test: add unit tests for latencystats library Naga Suresh Somarowthu
2018-07-26 12:50 ` [dpdk-dev] [PATCH v7 4/4] test: add unit test for pdump library Naga Suresh Somarowthu
2018-07-26 16:04 ` [dpdk-dev] [PATCH v7 0/4] add unit tests for bitrate, latency and pdump libraries Pattan, Reshma
2018-07-27 14:26 ` [dpdk-dev] [PATCH v8 " Naga Suresh Somarowthu
2018-07-27 14:26 ` [dpdk-dev] [PATCH v8 1/4] test: add helper functions for tests using ring-PMD Rx/Tx Naga Suresh Somarowthu
2018-07-27 14:26 ` [dpdk-dev] [PATCH v8 2/4] test: add unit tests for bitrate library Naga Suresh Somarowthu
2018-07-27 14:26 ` [dpdk-dev] [PATCH v8 3/4] test: add unit tests for latencystats library Naga Suresh Somarowthu
2018-07-27 14:26 ` [dpdk-dev] [PATCH v8 4/4] test: add unit test for pdump library Naga Suresh Somarowthu
2018-07-31 14:57 ` [dpdk-dev] [PATCH v8 0/4] add unit tests for bitrate, latency and pdump libraries Thomas Monjalon
2018-07-31 16:43 ` Pattan, Reshma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A36D1AD@IRSMSX109.ger.corp.intel.com \
--to=reshma.pattan@intel.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=remy.horton@intel.com \
--cc=tallurix.chaitanya.babu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).