From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Horton, Remy" <remy.horton@intel.com>,
"Babu Radhakrishnan,
AgalyaX" <agalyax.babu.radhakrishnan@intel.com>
Subject: Re: [dpdk-dev] [PATCH] test: add unit tests for latencystats library
Date: Tue, 10 Jul 2018 11:55:07 +0000 [thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A36D2DD@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <1530900059-9531-1-git-send-email-jananeex.m.parthasarathy@intel.com>
Hi,
> -----Original Message-----
> From: Parthasarathy, JananeeX M
> Sent: Friday, July 6, 2018 7:01 PM
> To: dev@dpdk.org
> Cc: Horton, Remy <remy.horton@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>; Parthasarathy, JananeeX M
> <jananeex.m.parthasarathy@intel.com>; Babu Radhakrishnan, AgalyaX
> <agalyax.babu.radhakrishnan@intel.com>
> Subject: [PATCH] test: add unit tests for latencystats library
>
> From: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
>
> Unit Test Cases added for latencystats library.
Need to mention dependency of sample oacket formward functions patch
> diff --git a/test/test/test_latencystats.c b/test/test/test_latencystats.c new file
> mode 100644 index 000000000..6d9809883
> --- /dev/null
> +++ b/test/test/test_latencystats.c
> +
> +/* Test case to get names of latency stats */ static int
> +test_latencystats_get_names(void)
> +{
> + int ret = 0;
> + int size = 0;
> + struct rte_metric_name names[NUM_STATS] = {0};
NUM_STATS is not defined here nor in sample_packet_forwrd code patch.
Am I missing something here.
Include this test to auto_test suite.
> + printf("Failed: Names are not matched");
> + }
Missing \n in printf.
Thanks,
Reshma
next prev parent reply other threads:[~2018-07-10 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 18:00 Jananee Parthasarathy
2018-07-10 11:55 ` Pattan, Reshma [this message]
2018-07-12 10:13 ` [dpdk-dev] [PATCH v2] " Jananee Parthasarathy
2018-07-12 16:11 ` Pattan, Reshma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A36D2DD@IRSMSX109.ger.corp.intel.com \
--to=reshma.pattan@intel.com \
--cc=agalyax.babu.radhakrishnan@intel.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).