From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Bie, Tiwei" <tiwei.bie@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>
Subject: Re: [dpdk-dev] [PATCH] pdump: remove deprecated APIs
Date: Thu, 13 Dec 2018 17:15:13 +0000 [thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A3EA30F@irsmsx110.ger.corp.intel.com> (raw)
In-Reply-To: <20181203025857.23670-1-tiwei.bie@intel.com>
Hi,
> -----Original Message-----
> From: Bie, Tiwei
> Sent: Monday, December 3, 2018 2:59 AM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Kovacevic, Marko <marko.kovacevic@intel.com>
> Subject: [PATCH] pdump: remove deprecated APIs
>
> We already changed to use generic IPC in pdump since below commit:
>
> commit 660098d61f57 ("pdump: use generic multi-process channel")
>
> The `rte_pdump_set_socket_dir()`, the `path` parameter of `rte_pdump_init()`
> and the `enum rte_pdump_socktype` have been deprecated since then. This
> commit removes these deprecated APIs and also bumps the pdump ABI.
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> changes:
> - update release notes;
> - minor updates in pdump_lib.rst;
>
> app/test-pmd/testpmd.c | 2 +-
> doc/guides/prog_guide/pdump_lib.rst | 18 ++++--------------
> doc/guides/rel_notes/deprecation.rst | 7 -------
> doc/guides/rel_notes/release_19_02.rst | 6 +++++-
> lib/librte_pdump/Makefile | 2 +-
> lib/librte_pdump/meson.build | 2 +-
> lib/librte_pdump/rte_pdump.c | 9 +--------
> lib/librte_pdump/rte_pdump.h | 34 +---------------------------------
> lib/librte_pdump/rte_pdump_version.map | 1 -
> 9 files changed, 14 insertions(+), 67 deletions(-)
>
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
next prev parent reply other threads:[~2018-12-13 17:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 2:55 [dpdk-dev] [RFC] " Tiwei Bie
2018-12-03 2:58 ` [dpdk-dev] [PATCH] " Tiwei Bie
2018-12-13 17:15 ` Pattan, Reshma [this message]
2018-12-19 0:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A3EA30F@irsmsx110.ger.corp.intel.com \
--to=reshma.pattan@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).