From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Hajkowski, MarcinX" <marcinx.hajkowski@intel.com>,
"Hunt, David" <david.hunt@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Hajkowski, MarcinX" <marcinx.hajkowski@intel.com>
Subject: Re: [dpdk-dev] [PATCH 4/4] power: send confirmation cmd to vm guest
Date: Fri, 15 Mar 2019 17:13:57 +0000 [thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A42E3C4@irsmsx110.ger.corp.intel.com> (raw)
In-Reply-To: <20190314144752.13812-5-marcinx.hajkowski@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hajkowski
> + int ret = -1;
> + if (valid_unit)
> + ret = send_ack_for_received_cmd(pkt,
> + chan_info,
> + scale_res ?
> CPU_POWER_CMD_ACK : CPU_POWER_CMD_NAK);
> + if (ret < 0)
> + RTE_LOG(DEBUG, CHANNEL_MONITOR, "Error during
> sending ack command "
> + "or unexpected unit type.\n");
> +
> }
This if check should go inside for if(valid_unit)?, otherwise this would applicable for valid_unit == false also.
Also do we need to handle valid_unit ==false case? Do we need to send back message to guest saying invalid command.
Thanks,
Reshma
next prev parent reply other threads:[~2019-03-15 17:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 14:47 [dpdk-dev] [PATCH 0/4] bidirect guest channel Hajkowski
2019-03-14 14:47 ` Hajkowski
2019-03-14 14:47 ` [dpdk-dev] [PATCH 1/4] power: fix invalid socket indicator value Hajkowski
2019-03-14 14:47 ` Hajkowski
2019-03-14 14:47 ` [dpdk-dev] [PATCH 2/4] power: extend guest channel api for reading Hajkowski
2019-03-14 14:47 ` Hajkowski
2019-03-14 14:47 ` [dpdk-dev] [PATCH 3/4] power: process incoming confirmation cmds Hajkowski
2019-03-14 14:47 ` Hajkowski
2019-03-14 14:47 ` [dpdk-dev] [PATCH 4/4] power: send confirmation cmd to vm guest Hajkowski
2019-03-14 14:47 ` Hajkowski
2019-03-15 16:29 ` Pattan, Reshma
2019-03-15 16:29 ` Pattan, Reshma
2019-03-15 17:13 ` Pattan, Reshma [this message]
2019-03-15 17:13 ` Pattan, Reshma
2019-03-18 12:40 ` Hajkowski, MarcinX
2019-03-18 12:40 ` Hajkowski, MarcinX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A42E3C4@irsmsx110.ger.corp.intel.com \
--to=reshma.pattan@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=marcinx.hajkowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).