From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: Harman Kalra <hkalra@marvell.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/2] metrics: new API to deinitialise metrics library
Date: Thu, 27 Jun 2019 10:59:12 +0000 [thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A4881C5@irsmsx110.ger.corp.intel.com> (raw)
In-Reply-To: <1551434828-3518-1-git-send-email-hkalra@marvell.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harman Kalra
> Sent: Friday, March 1, 2019 10:08 AM
> To: Horton, Remy <remy.horton@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Harman Kalra <hkalra@marvell.com>
> Subject: [dpdk-dev] [PATCH v2 1/2] metrics: new API to deinitialise metrics
> library
>
> Once the library usage is over, it must be deinitialized which will free the
> shared memory reserved during initialization.
>
> Fixes: observed an issue while running 'metrics_autotest'
> continuously without quiting. For the first run 'metrics_autotest'
> passes all test cases but second run onwards first test case fails because
> metrics library is already initialized during first run.
> Cc: stable@dpdk.org
>
> Signed-off-by: Harman Kalra <hkalra@marvell.com>
> ---
> v2:
> * Adding stable@dpdk.org into cc as this patch falls between bug fix and
> new feature.
>
> doc/guides/prog_guide/metrics_lib.rst | 14 ++++++++++++++
> lib/librte_metrics/rte_metrics.c | 20 ++++++++++++++++++++
> lib/librte_metrics/rte_metrics.h | 17 +++++++++++++++++
> lib/librte_metrics/rte_metrics_version.map | 6 ++++++
> 4 files changed, 57 insertions(+)
>
> diff --git a/doc/guides/prog_guide/metrics_lib.rst
> b/doc/guides/prog_guide/metrics_lib.rst
> index e68e4e743..08e107df3 100644
> --- a/doc/guides/prog_guide/metrics_lib.rst
> +++ b/doc/guides/prog_guide/metrics_lib.rst
> @@ -154,6 +154,20 @@ print out all metrics for a given port:
> }
>
>
> +Deinitialising the library
> +------------------------
1)
The underline should be same length as heading. Below is the error from "make doc-guides-html"
sphinx processing guides-html...
metrics_lib.rst:158: WARNING: Title underline too short.
Deinitialising the library
------------------------
metrics_lib.rst:158: WARNING: Title underline too short.
2) Need to fix below
./devtools/check-git-log.sh
Wrong tag:
Fixes: observed an issue while running 'metrics_autotest'
Wrong 'Fixes' reference:
Fixes: observed an issue while running 'metrics_autotest'
If you want to add Fixes line it should be of below form
Fixes: <commitd> ("commit heading")
Ex: Fixes: d7a0da3c0043 ("mempool/octeontx2: add fast path mempool ops")
Otherwise,
Tested-by : Reshma Pattan <reshma.pattan@intel.com>
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
Please keep these tags for next versions, otherwise it can easily miss from being applied.
Thanks,
Reshma
next prev parent reply other threads:[~2019-06-27 10:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6343c206-78f0-e4cf-9dc9-574ce7d6e743@intel.com>
2019-02-27 10:51 ` [dpdk-stable] [PATCH " Harman Kalra
2019-03-01 10:07 ` [dpdk-stable] [PATCH v2 " Harman Kalra
2019-03-01 10:07 ` [dpdk-stable] [PATCH v2 2/2] test/metrics: first test case fails on continuous Harman Kalra
2019-06-27 10:59 ` Pattan, Reshma [this message]
2019-06-27 11:03 ` [dpdk-stable] [dpdk-dev] [PATCH v2 1/2] metrics: new API to deinitialise metrics library Pattan, Reshma
2019-07-10 10:52 ` [dpdk-stable] [PATCH v3 " Harman Kalra
2019-07-10 10:52 ` [dpdk-stable] [PATCH v3 2/2] test/metrics: fix metrics autotest failure Harman Kalra
2019-07-10 22:08 ` [dpdk-stable] [PATCH v3 1/2] metrics: new API to deinitialise metrics library Thomas Monjalon
2019-07-11 8:12 ` Harman Kalra
2019-07-11 8:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A4881C5@irsmsx110.ger.corp.intel.com \
--to=reshma.pattan@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).