From: "Mokhtar, Amr" <amr.mokhtar@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Power, Niall" <niall.power@intel.com>,
"Macnamara, Chris" <chris.macnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library
Date: Wed, 18 Oct 2017 02:25:05 +0000 [thread overview]
Message-ID: <3D3765A8CDB52A4C8B410430AA19CB236EC43A6A@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC3463B@IRSMSX108.ger.corp.intel.com>
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Monday 16 October 2017 11:04
> To: Mokhtar, Amr <amr.mokhtar@intel.com>; dev@dpdk.org
> Cc: Power, Niall <niall.power@intel.com>; Macnamara, Chris
> <chris.macnamara@intel.com>; Mokhtar, Amr <amr.mokhtar@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Amr Mokhtar
> > Sent: Saturday, September 30, 2017 2:38 AM
> > To: dev@dpdk.org
> > Cc: Power, Niall <niall.power@intel.com>; Macnamara, Chris
> > <chris.macnamara@intel.com>; Mokhtar, Amr <amr.mokhtar@intel.com>
> > Subject: [dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library
> >
>
> You are adding a new library here, so I think it deserves a description here (also
> for the other patches).
Wrong command caused the cover letter to go separately. You may find it @ http://dpdk.org/ml/archives/dev/2017-September/077027.html
Recovered in v2 patch.
>
> This is also a good patch to mention the new library in release notes (instead of
> leaving it to the documentation patch).
This was considered in v2 patch. Thanks.
>
>
> > Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>
>
> ...
>
> b/lib/librte_bbdev/Makefile
> > new file mode 100644
> > index 0000000..519d49f
> > --- /dev/null
> > +++ b/lib/librte_bbdev/Makefile
>
> ...
>
> > +
> > +# versioning export map
> > +EXPORT_MAP := rte_bbdev_version.map
> > +
> > +# library dependencies
> > +DEPDIRS-y += lib/librte_eal lib/librte_mempool lib/librte_kvargs
>
> Since this patch, DEPDIRS in libraries and drivers are deprecated:
> http://dpdk.org/dev/patchwork/patch/22298/
Done.
>
>
> > +
> > +include $(RTE_SDK)/mk/rte.lib.mk
prev parent reply other threads:[~2017-10-18 2:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-30 1:37 Amr Mokhtar
2017-09-30 1:37 ` [dpdk-dev] [PATCH v1 2/6] bbdev: PMD drivers (null/turbo_sw) Amr Mokhtar
2017-09-30 1:37 ` [dpdk-dev] [PATCH v1 3/6] bbdev: test applications Amr Mokhtar
2017-09-30 1:37 ` [dpdk-dev] [PATCH v1 4/6] bbdev: sample app Amr Mokhtar
2017-09-30 1:37 ` [dpdk-dev] [PATCH v1 5/6] bbdev: documentation Amr Mokhtar
2017-09-30 1:37 ` [dpdk-dev] [PATCH v1 6/6] bbdev: auxiliary changes to DPDK framework Amr Mokhtar
2017-10-04 16:14 ` Burakov, Anatoly
2017-10-16 9:00 ` Mokhtar, Amr
2017-10-16 10:03 ` [dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library De Lara Guarch, Pablo
2017-10-18 2:25 ` Mokhtar, Amr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D3765A8CDB52A4C8B410430AA19CB236EC43A6A@IRSMSX101.ger.corp.intel.com \
--to=amr.mokhtar@intel.com \
--cc=chris.macnamara@intel.com \
--cc=dev@dpdk.org \
--cc=niall.power@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).