From: Levend Sayar <levendsayar@gmail.com>
To: "Guo, Junfeng" <junfeng.guo@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats
Date: Thu, 23 Feb 2023 09:28:36 +0300 [thread overview]
Message-ID: <3E7EF1E9-7A5A-4F67-BF2E-B5B6C3BB9911@gmail.com> (raw)
In-Reply-To: <DM6PR11MB3723A42C06BF1CFD68A10F83E7AB9@DM6PR11MB3723.namprd11.prod.outlook.com>
Thanks Junfeng for acknowledging.
> On 23 Feb 2023, at 05:49, Guo, Junfeng <junfeng.guo@intel.com> wrote:
>
> Thanks!
>
>> -----Original Message-----
>> From: Levend Sayar <levendsayar@gmail.com>
>> Sent: Wednesday, February 22, 2023 00:44
>> To: Ferruh Yigit <ferruh.yigit@amd.com>
>> Cc: Guo, Junfeng <junfeng.guo@intel.com>; dev@dpdk.org
>> Subject: Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats
>>
>> Thanks Ferruh for the review.
>>
>>> On 21 Feb 2023, at 18:58, Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>>>
>>> On 2/21/2023 2:18 PM, Levend Sayar wrote:
>>>> Google Virtual NIC rx/tx queue stats are added as extended stats.
>>>>
>>>> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
>>>
>>> Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
>>>
>
> Acked-by: Junfeng Guo <junfeng.guo@intel.com>
>
>>> <...>
>>>
>>>> @@ -20,6 +20,7 @@ gve_rx_refill(struct gve_rx_queue *rxq)
>>>> if (nb_alloc <= rxq->nb_avail) {
>>>> diag = rte_pktmbuf_alloc_bulk(rxq->mpool, &rxq-
>>> sw_ring[idx], nb_alloc);
>>>> if (diag < 0) {
>>>> + rxq->stats.no_mbufs_bulk++;
>>>
>>> It is not common to record bulk alloc failures, but as 'no_mbufs'
>>> already recorded conventionally, I guess it is OK to keep this extra
>>> stat if it is helpful.
>>>
>
next prev parent reply other threads:[~2023-02-23 6:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 0:30 [PATCH] net/gve: fix Rx no mbufs stats counter update Levend Sayar
2023-02-19 17:35 ` Stephen Hemminger
2023-02-19 20:43 ` Levend Sayar
2023-02-19 22:59 ` Stephen Hemminger
2023-02-20 15:19 ` [PATCH v2] " Levend Sayar
2023-02-20 21:11 ` [PATCH v3 1/2] " Levend Sayar
2023-02-20 21:11 ` [PATCH v3 2/2] net/gve: add Rx/Tx queue stats as extended stats Levend Sayar
2023-02-20 22:57 ` Ferruh Yigit
2023-02-21 11:11 ` Levend Sayar
2023-02-21 14:13 ` [PATCH v4] " Levend Sayar
2023-02-21 14:18 ` [PATCH v5] " Levend Sayar
2023-02-21 15:58 ` Ferruh Yigit
2023-02-21 16:44 ` Levend Sayar
2023-02-23 2:49 ` Guo, Junfeng
2023-02-23 6:28 ` Levend Sayar [this message]
2023-02-23 11:09 ` Ferruh Yigit
2023-02-23 12:30 ` Levend Sayar
2023-02-20 22:57 ` [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update Ferruh Yigit
2023-02-21 10:07 ` Levend Sayar
2023-02-21 10:30 ` Ferruh Yigit
2023-02-23 4:34 ` Guo, Junfeng
2023-02-23 6:29 ` Levend Sayar
2023-02-23 11:10 ` Ferruh Yigit
2023-02-23 12:29 ` Levend Sayar
2023-02-21 15:58 ` Ferruh Yigit
2023-02-21 16:42 ` Levend Sayar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E7EF1E9-7A5A-4F67-BF2E-B5B6C3BB9911@gmail.com \
--to=levendsayar@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=junfeng.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).