From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check
Date: Wed, 26 Jul 2017 15:17:42 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BA8556D@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1501080853-88038-1-git-send-email-wenzhuo.lu@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Wednesday, July 26, 2017 3:54 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check
>
> If there's no Traffic Management node added,
> not necessary to check if TM is committed.
>
> Fixes: 5713ade69776 ("net/ixgbe: support committing TM hierarchy")
>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 194058f..e436dca 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2693,7 +2693,7 @@ static int eth_ixgbevf_pci_remove(struct
> rte_pci_device *pci_dev)
> ixgbe_l2_tunnel_conf(dev);
> ixgbe_filter_restore(dev);
>
> - if (!tm_conf->committed)
> + if (tm_conf->root && !tm_conf->committed)
> PMD_DRV_LOG(WARNING,
> "please call hierarchy_commit() "
> "before starting the port");
> --
> 1.9.3
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
next prev parent reply other threads:[~2017-07-26 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 14:54 Wenzhuo Lu
2017-07-26 15:17 ` Dumitrescu, Cristian [this message]
2017-07-31 16:53 ` Thomas Monjalon
2017-07-26 15:20 ` Wiles, Keith
2017-07-26 15:21 ` Wiles, Keith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D891267BA8556D@IRSMSX108.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).