From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Alan Dewar <alangordondewar@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Kantecki, Tomasz" <tomasz.kantecki@intel.com>
Subject: Re: [dpdk-dev] [PATCH] sched: make RED scaling configurable
Date: Thu, 31 Aug 2017 09:53:39 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BAAFBFF@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1504170013-5887-1-git-send-email-alan.dewar@att.com>
CC-ing Tomasz, the author of rte_red.[hc].
> -----Original Message-----
> From: Alan Dewar [mailto:alangordondewar@gmail.com]
> Sent: Thursday, August 31, 2017 10:00 AM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] sched: make RED scaling configurable
>
> The RED code stores the maximum threshold is a 32-bit integer as a
> pseudo fixed-point floating number with 10 fractional bits. Twelve
> other bits are used to encode the filter weight, leaving just 10 bits
> for the queue length. This limits the maximum queue length supported
> by RED queues as 1024 packets.
>
> Move the "hard" definitions from red.h into config/common_base so that
> RED scaling can be configured during build.
>
> Signed-off-by: Alan Dewar <alan.dewar@att.com>
> ---
> config/common_base | 2 ++
> lib/librte_sched/rte_red.h | 3 +--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/config/common_base b/config/common_base
> index 5e97a08..5501dfe 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -666,6 +666,8 @@ CONFIG_RTE_SCHED_COLLECT_STATS=n
> CONFIG_RTE_SCHED_SUBPORT_TC_OV=n
> CONFIG_RTE_SCHED_PORT_N_GRINDERS=8
> CONFIG_RTE_SCHED_VECTOR=n
> +CONFIG_RTE_RED_SCALING=10
> +CONFIG_RTE_RED_MAX_TH_MAX=1023
>
> #
> # Compile the distributor library
> diff --git a/lib/librte_sched/rte_red.h b/lib/librte_sched/rte_red.h
> index ca12227..49d3379 100644
> --- a/lib/librte_sched/rte_red.h
> +++ b/lib/librte_sched/rte_red.h
> @@ -51,10 +51,9 @@ extern "C" {
> #include <rte_debug.h>
> #include <rte_cycles.h>
> #include <rte_branch_prediction.h>
> +#include <rte_config.h>
>
> -#define RTE_RED_SCALING 10 /**< Fraction size for fixed-
> point */
> #define RTE_RED_S (1 << 22) /**< Packet size multiplied by
> number of leaf queues */
> -#define RTE_RED_MAX_TH_MAX 1023 /**< Max threshold limit
> in fixed point format */
> #define RTE_RED_WQ_LOG2_MIN 1 /**< Min inverse filter
> weight value */
> #define RTE_RED_WQ_LOG2_MAX 12 /**< Max inverse filter
> weight value */
> #define RTE_RED_MAXP_INV_MIN 1 /**< Min inverse mark
> probability value */
> --
> 2.1.4
next parent reply other threads:[~2017-08-31 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1504170013-5887-1-git-send-email-alan.dewar@att.com>
2017-08-31 9:53 ` Dumitrescu, Cristian [this message]
2017-09-01 13:41 alangordondewar
2017-09-11 15:51 ` Kantecki, Tomasz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D891267BAAFBFF@IRSMSX108.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=alangordondewar@gmail.com \
--cc=dev@dpdk.org \
--cc=tomasz.kantecki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).