From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Rongqiang XIE <xie.rongqiang@zte.com.cn>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>
Subject: Re: [dpdk-dev] [PATCH] lib/librte_pipeline:fix the array index out of bound
Date: Wed, 20 Sep 2017 12:01:29 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BABCE0E@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1503471932-22577-1-git-send-email-xie.rongqiang@zte.com.cn>
> -----Original Message-----
> From: Rongqiang XIE [mailto:xie.rongqiang@zte.com.cn]
> Sent: Wednesday, August 23, 2017 8:06 AM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; Rongqiang XIE <xie.rongqiang@zte.com.cn>
> Subject: [PATCH] lib/librte_pipeline:fix the array index out of bound
>
> In function rte_pipeline_compute_masks(), the value pos equal
> p->entries[i]->action,type constraint p->entries[i]->action is
> [0,4],but array action_mask1 size is 4,it possible attempt to
> access element 4 of array action_mask1.And also in function
> rte_pipeline_run(),it possible attempt to access element 4 of
> array action_mask0.
>
> Signed-off-by: Rongqiang XIE <xie.rongqiang@zte.com.cn>
> ---
> lib/librte_pipeline/rte_pipeline.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_pipeline/rte_pipeline.c
> b/lib/librte_pipeline/rte_pipeline.c
> index 7f8fbac..2914445 100644
> --- a/lib/librte_pipeline/rte_pipeline.c
> +++ b/lib/librte_pipeline/rte_pipeline.c
> @@ -155,8 +155,8 @@ struct rte_pipeline {
> /* Pipeline run structures */
> struct rte_mbuf *pkts[RTE_PORT_IN_BURST_SIZE_MAX];
> struct rte_pipeline_table_entry
> *entries[RTE_PORT_IN_BURST_SIZE_MAX];
> - uint64_t action_mask0[RTE_PIPELINE_ACTIONS];
> - uint64_t action_mask1[RTE_PIPELINE_ACTIONS];
> + uint64_t action_mask0[RTE_PIPELINE_ACTIONS + 1];
> + uint64_t action_mask1[RTE_PIPELINE_ACTIONS + 1];
> uint64_t pkts_mask;
> uint64_t n_pkts_ah_drop;
> uint64_t pkts_drop_mask;
> --
> 1.8.3.1
>
>
NAK
Hi Rongqiang,
Thanks for your patch, but I think there is a confusion on your side here:
pos = p->entries[i]->action can only be 0 .. 3 (and not: 0 .. 4), as the last value in the enum rte_pipeline_action, namely RTE_PIPELINE_ACTIONS (equal to 4), is not a valid action, but the number of valid actions (which are specified by enu values 0 ..3).
Makes sense?
Regards,
Cristian
prev parent reply other threads:[~2017-09-20 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 7:05 Rongqiang XIE
2017-09-04 13:37 ` Singh, Jasvinder
2017-09-20 12:01 ` Dumitrescu, Cristian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D891267BABCE0E@IRSMSX108.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=xie.rongqiang@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).