From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Alan Dewar <alangordondewar@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] rte_sched: don't count RED-drops as tail-drops
Date: Mon, 25 Sep 2017 11:05:37 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BAC0788@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1503576011-11389-1-git-send-email-alan.dewar@att.com>
>
> Packets that are RED-dropped are not Tail-dropped, so the n_pkts_dropped
> counter should not be incremented when the n_pkts_red_dropped counter
> is.
>
Hi Alan,
Not really:
* The n_pkts_dropped counter is intended to be incremented every time a packet is dropped, regardless of the drop cause (either tail drop or RED), so it is cumulative of all drop causes.
* The n_pkts_red_dropped counter is only incremented when the drop cause is RED, so it represents a slice of n_pkts_dropped. Therefore, the number of packets dropped due to tail drop is (n_pkts_dropped - n_pkts_red_dropped).
So NAK.
Thanks,
Cristian
prev parent reply other threads:[~2017-09-25 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 12:00 Alan Dewar
2017-09-25 11:05 ` Dumitrescu, Cristian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D891267BAC0788@IRSMSX108.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=alangordondewar@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).