From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Moti Haimovsky <motih@mellanox.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: workaround softnic CLI modifications
Date: Tue, 24 Jul 2018 17:39:19 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E779325@IRSMSX107.ger.corp.intel.com> (raw)
In-Reply-To: <1532449282-9352-1-git-send-email-motih@mellanox.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Moti Haimovsky
> Sent: Tuesday, July 24, 2018 5:21 PM
> To: thomas@monjalon.net
> Cc: dev@dpdk.org; stable@dpdk.org; Moti Haimovsky
> <motih@mellanox.com>
> Subject: [dpdk-dev] [PATCH] app/testpmd: workaround softnic CLI
> modifications
>
> This patch returns the previous testpmd command line handling
> routines (namely cmdline_interact and cmdline_stdin_exit) to the
> prompt routine in order to overcome testpmd abnormal exit observed on
> several setups.
> These routines will only by used when testpmd is compiled without
> support for RTE_LIBRTE_PMD_SOFTNIC
>
> Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> ---
> app/test-pmd/cmdline.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
We should probably fix the issue in the cmdline library to bring cmdline_poll() on parity with cmdline_interact(), but this is a decent workaround to avoid breaking those automation scripts that rely on Ctrl+D behavior.
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
next prev parent reply other threads:[~2018-07-24 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 16:21 [dpdk-stable] " Moti Haimovsky
2018-07-24 17:39 ` Dumitrescu, Cristian [this message]
2018-07-25 8:21 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D891268E779325@IRSMSX107.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=motih@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).