From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: 'Vivek Sharma' <vivek.sharma@caviumnetworks.com>
Cc: "'Sharma, Vivek'" <Vivek.Sharma@cavium.com>,
"'stable@dpdk.org'" <stable@dpdk.org>,
"'dev@dpdk.org'" <dev@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v1] eal: use correct data type for slab operations
Date: Mon, 8 Oct 2018 15:57:22 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891268E7D5F73@IRSMSX107.ger.corp.intel.com> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E7B0AB8@IRSMSX107.ger.corp.intel.com>
> -----Original Message-----
> From: Dumitrescu, Cristian
> Sent: Monday, September 24, 2018 6:12 PM
> To: Vivek Sharma <vivek.sharma@caviumnetworks.com>
> Cc: Sharma, Vivek <Vivek.Sharma@cavium.com>; stable@dpdk.org;
> dev@dpdk.org
> Subject: RE: [PATCH v1] eal: use correct data type for slab operations
>
>
>
> > -----Original Message-----
> > From: Vivek Sharma [mailto:vivek.sharma@caviumnetworks.com]
> > Sent: Monday, September 24, 2018 4:50 PM
> > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> > Cc: Sharma, Vivek <Vivek.Sharma@cavium.com>; stable@dpdk.org;
> > dev@dpdk.org
> > Subject: Re: [PATCH v1] eal: use correct data type for slab operations
> >
> > + dev.
> > +cristian(Bitmap maintainer)
> >
> > Please review.
> >
> > Thanks!
> >
> > On Monday 24 September 2018 09:08 PM, Vivek Sharma wrote:
> > > Currently, slab operations use unsigned long data type for 64-bit slab
> > > related operations. On target 'i686-native-linuxapp-gcc', unsigned long
> > > is 32-bit and thus, slab operations breaks on this target. Changing slab
> > > operations to use unsigned long long for correct functioning on all
> targets.
> > >
> > > Fixes: de3cfa2c9823 ("sched: initial import")
> > > Fixes: 693f715da45c ("remove extra parentheses in return statement")
> > > CC: stable@dpdk.org
> > >
> > > Signed-off-by: Vivek Sharma <vivek.sharma@caviumnetworks.com>
> > > ---
> > > lib/librte_eal/common/include/rte_bitmap.h | 14 +++++++-------
> > > test/test/test_bitmap.c | 18 ++++++++++++++++++
> > > 2 files changed, 25 insertions(+), 7 deletions(-)
> > >
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied to next-qos tree, thanks!
next prev parent reply other threads:[~2018-10-08 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 15:38 Vivek Sharma
2018-09-24 15:50 ` Vivek Sharma
2018-09-24 17:12 ` Dumitrescu, Cristian
2018-10-08 15:57 ` Dumitrescu, Cristian [this message]
2018-09-25 9:53 ` [dpdk-stable] [PATCH v2] eal: use correct data type for bitmap " Vivek Sharma
2018-09-25 12:38 ` [dpdk-stable] [PATCH v1] eal: use correct data type for " Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D891268E7D5F73@IRSMSX107.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=Vivek.Sharma@cavium.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=vivek.sharma@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).