From: "Wiles, Keith" <keith.wiles@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 12/12] net/tap: fix incorrect rxq errors stat
Date: Mon, 4 Mar 2019 13:58:20 +0000 [thread overview]
Message-ID: <3FAC8250-264B-4750-A848-108F00760D49@intel.com> (raw)
In-Reply-To: <1551698315-2611-13-git-send-email-david.marchand@redhat.com>
> On Mar 4, 2019, at 5:18 AM, David Marchand <david.marchand@redhat.com> wrote:
>
> Transmit errors must not be reported in q_errors[] which is for
> reception.
>
> Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
> Cc: stable@dpdk.org
> Cc: Keith Wiles <keith.wiles@intel.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 6f5109f..94c728f 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -968,10 +968,9 @@ struct ipc_queues {
>
> for (i = 0; i < imax; i++) {
> tap_stats->q_opackets[i] = pmd->txq[i].stats.opackets;
> - tap_stats->q_errors[i] = pmd->txq[i].stats.errs;
> tap_stats->q_obytes[i] = pmd->txq[i].stats.obytes;
> tx_total += tap_stats->q_opackets[i];
> - tx_err_total += tap_stats->q_errors[i];
> + tx_err_total += pmd->txq[i].stats.errs;
> tx_bytes_total += tap_stats->q_obytes[i];
> }
>
> --
> 1.8.3.1
>
Acked-by: Keith Wiles <keith.wiles@intel.com>
Regards,
Keith
prev parent reply other threads:[~2019-03-04 13:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1551698315-2611-1-git-send-email-david.marchand@redhat.com>
2019-03-04 11:18 ` [dpdk-stable] [PATCH 01/12] net/af_packet: " David Marchand
2019-03-04 11:18 ` [dpdk-stable] [PATCH 02/12] net/avp: " David Marchand
2019-03-04 12:18 ` Legacy, Allain
2019-03-04 11:18 ` [dpdk-stable] [PATCH 03/12] net/bnxt: " David Marchand
2019-03-04 11:18 ` [dpdk-stable] [PATCH 04/12] net/cxgbe: " David Marchand
2019-03-04 11:18 ` [dpdk-stable] [PATCH 05/12] net/kni: " David Marchand
2019-03-04 11:18 ` [dpdk-stable] [PATCH 06/12] net/mlx4: " David Marchand
2019-03-05 8:19 ` Shahaf Shuler
2019-03-04 11:18 ` [dpdk-stable] [PATCH 07/12] net/mlx5: " David Marchand
2019-03-05 8:18 ` Shahaf Shuler
2019-03-04 11:18 ` [dpdk-stable] [PATCH 08/12] net/null: " David Marchand
2019-03-04 11:18 ` [dpdk-stable] [PATCH 09/12] net/pcap: " David Marchand
2019-03-04 11:18 ` [dpdk-stable] [PATCH 10/12] net/ring: " David Marchand
2019-03-04 11:18 ` [dpdk-stable] [PATCH 11/12] net/szedata2: " David Marchand
2019-03-04 11:18 ` [dpdk-stable] [PATCH 12/12] net/tap: " David Marchand
2019-03-04 13:58 ` Wiles, Keith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FAC8250-264B-4750-A848-108F00760D49@intel.com \
--to=keith.wiles@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).