From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Reshma Pattan <reshma.pattan@intel.com>, dev@dpdk.org
Cc: jasvinder.singh@intel.com, bernard.iremonger@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] test: fix incorrect return types
Date: Tue, 17 Jul 2018 10:28:28 +0100 [thread overview]
Message-ID: <3b00cf4a-4557-1c02-2a3b-e8df75cf32b8@intel.com> (raw)
In-Reply-To: <1531760319-2996-1-git-send-email-reshma.pattan@intel.com>
On 16-Jul-18 5:58 PM, Reshma Pattan wrote:
> UTs should return either TEST_SUCCESS or TEST_FAILED only.
> They should not return 0, -1 and any other value.
>
> Fixes: 9c9befea4f ("test: add flow classify unit tests")
> CC: jasvinder.singh@intel.com
> CC: bernard.iremonger@intel.com
> CC: stable@dpdk.org
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
Perhaps it should be highlighted that along with making them return
TEST_SUCCESS/FAILURE, you're also fixing the -ENOMEM return in one of
the code paths.
Otherwise,
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-07-17 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 16:58 [dpdk-stable] " Reshma Pattan
2018-07-17 9:28 ` Burakov, Anatoly [this message]
2018-07-17 12:39 ` [dpdk-stable] [PATCH v2] " Reshma Pattan
2018-07-17 12:58 ` Burakov, Anatoly
2018-07-17 13:51 ` Pattan, Reshma
2018-07-17 16:44 ` [dpdk-stable] [PATCH v3] " Reshma Pattan
2018-07-26 19:41 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b00cf4a-4557-1c02-2a3b-e8df75cf32b8@intel.com \
--to=anatoly.burakov@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).