From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Kevin Traynor <ktraynor@redhat.com>,
xuan.ding@intel.com, chenbo.xia@intel.com
Cc: dev@dpdk.org, jiayu.hu@intel.com, yuanx.wang@intel.com
Subject: Re: [PATCH v2 0/2] vhost: fix async address mapping
Date: Fri, 4 Feb 2022 11:43:17 +0100 [thread overview]
Message-ID: <3be61db5-b63a-7daa-098c-dd409203a37a@redhat.com> (raw)
In-Reply-To: <2c4069f6-ea11-aebc-dc17-5c49ce6cf19c@redhat.com>
On 2/1/22 12:29, Kevin Traynor wrote:
> On 01/02/2022 08:28, Maxime Coquelin wrote:
>>
>>
>> On 1/19/22 16:10, xuan.ding@intel.com wrote:
>>> From: Xuan Ding <xuan.ding@intel.com>
>>>
>>> This patchset fixes the issue of incorrect DMA mapping in PA mode.
>>> Due to the ambiguity of host_phys_addr naming in the guest page
>>> struct, rename it to host_iova.
>>>
>>> v2:
>>> * Change the order of patch.
>>
>> I'm not sure why you changed the order of the patches.
>> Now, the second one is the fix, so it will make the backport more
>> difficult. Either both are considered to be fixes. I think it can make
>> sense as the renaming does not introduce risk of regression and will
>> make backporting patches easier in the future.
>>
>> Other solution is to reverse the order again, but I think tagging the
>> renaming as a fix is OK for me here.
>>
>> What do you think?
>>
>
> Either way sounds ok to me, but can you also add stable tag(s). There
> isn't a stable tag on either patch at present. Thanks.
OK, will do.
Thanks Kevin,
Maxime
>> Regards,
>> Maxime
>>
>>>
>>> Xuan Ding (2):
>>> vhost: rename field in guest page struct
>>> vhost: fix physical address mapping
>>>
>>> lib/vhost/vhost.h | 11 ++--
>>> lib/vhost/vhost_user.c | 130
>>> ++++++++++++++++++++---------------------
>>> lib/vhost/virtio_net.c | 11 ++--
>>> 3 files changed, 75 insertions(+), 77 deletions(-)
>>>
>>
>
next prev parent reply other threads:[~2022-02-04 10:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 15:10 xuan.ding
2022-01-19 15:10 ` [PATCH v2 1/2] vhost: rename field in guest page struct xuan.ding
2022-02-01 8:47 ` Maxime Coquelin
2022-01-19 15:10 ` [PATCH v2 2/2] vhost: fix physical address mapping xuan.ding
2022-02-01 8:51 ` Maxime Coquelin
2022-02-04 10:43 ` Maxime Coquelin
2022-02-01 8:28 ` [PATCH v2 0/2] vhost: fix async " Maxime Coquelin
2022-02-01 11:29 ` Kevin Traynor
2022-02-04 10:43 ` Maxime Coquelin [this message]
2022-02-04 10:56 ` Maxime Coquelin
2022-02-11 2:48 ` Ding, Xuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3be61db5-b63a-7daa-098c-dd409203a37a@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=ktraynor@redhat.com \
--cc=xuan.ding@intel.com \
--cc=yuanx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).