From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Ciara Power <ciara.power@intel.com>,
thomas@monjalon.net, mtetsuyah@gmail.com,
bruce.richardson@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add check for device promiscuous state
Date: Tue, 22 Oct 2019 09:18:54 +0100 [thread overview]
Message-ID: <3cf9d8f5-4ef8-2de4-3d1b-3d48b5e7cdbf@intel.com> (raw)
In-Reply-To: <9dedc804-c3c4-768e-f907-7c4868fcde05@solarflare.com>
On 10/22/2019 8:03 AM, Andrew Rybchenko wrote:
> On 10/21/19 3:22 PM, Ciara Power wrote:
>> The promiscuous enable and disable functions now check the
>> promiscuous state of the device before checking if the dev_ops
>> function exists for the device.
>>
>> This change is necessary to allow sample applications run on
>> virtual PMDs, as previously -ENOTSUP returned when the promiscuous
>> enable function was called. This caused the sample application to
>> fail unnecessarily.
>>
>> Signed-off-by: Ciara Power <ciara.power@intel.com>
>
> Many thanks,
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
Series applied to dpdk-next-net/master, thanks.
next prev parent reply other threads:[~2019-10-22 8:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 12:22 [dpdk-dev] [PATCH v2 0/2] enable virtual PMD promiscuous and multicast Ciara Power
2019-10-21 12:22 ` [dpdk-dev] [PATCH v2 1/2] ethdev: add check for device promiscuous state Ciara Power
2019-10-21 18:39 ` Ferruh Yigit
2019-10-22 7:03 ` Andrew Rybchenko
2019-10-22 8:18 ` Ferruh Yigit [this message]
2019-10-21 12:22 ` [dpdk-dev] [PATCH v2 2/2] drivers/net: set enabled promiscuous and multicast Ciara Power
2019-10-21 18:40 ` Ferruh Yigit
2019-10-22 7:12 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cf9d8f5-4ef8-2de4-3d1b-3d48b5e7cdbf@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=mtetsuyah@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).