From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Hunt, David" <david.hunt@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Guo, Jia" <jia.guo@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 2/2] net/i40e: allow get_monitor_addr for VF driver
Date: Wed, 28 Apr 2021 01:22:02 +0000 [thread overview]
Message-ID: <3d14731d9c8f46078f5bc453ff416da0@intel.com> (raw)
In-Reply-To: <fd97c75e-4f69-8697-4f50-a20e8aa720fa@intel.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of David Hunt
> Sent: Monday, April 26, 2021 10:23 PM
> To: Burakov, Anatoly <anatoly.burakov@intel.com>; dev@dpdk.org; Xing,
> Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Ananyev,
> Konstantin <konstantin.ananyev@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1 2/2] net/i40e: allow get_monitor_addr for
> VF driver
>
> Hi Anatoly,
>
> On 26/4/2021 2:49 PM, Anatoly Burakov wrote:
> > When .get_monitor_addr API was introduced, it was implemented in the
> > i40e driver, but only for the physical function; the virtual function
> > portion of the driver does not support that API.
> >
> > Add the missing function pointer to VF device structure.
> >
> > The i40e driver is not meant to use the VF portion any more, as
> > currently i40e VF devices are supposed to be managed by iavf drier,
> > but add this just in case it needs backporting later.
> >
> > Fixes: a683abf90a22 ("net/i40e: implement power management API")
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
> > drivers/net/i40e/i40e_ethdev_vf.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> > b/drivers/net/i40e/i40e_ethdev_vf.c
> > index 3c258ba7cf..156ad9ab96 100644
> > --- a/drivers/net/i40e/i40e_ethdev_vf.c
> > +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> > @@ -216,6 +216,7 @@ static const struct eth_dev_ops i40evf_eth_dev_ops
> = {
> > .mtu_set = i40evf_dev_mtu_set,
> > .mac_addr_set = i40evf_set_default_mac_addr,
> > .tx_done_cleanup = i40e_tx_done_cleanup,
> > + .get_monitor_addr = i40e_get_monitor_addr
> > };
> >
> > /*
>
>
> Same issue as the ixgbe, get_monitor_addr op missing for the vf portion of the
> driver. Thanks.
>
> Reviewed-by: David Hunt <david.hunt@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
>
>
>
next prev parent reply other threads:[~2021-04-28 1:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 13:49 [dpdk-dev] [PATCH v1 1/2] net/ixgbe: " Anatoly Burakov
2021-04-26 13:49 ` [dpdk-dev] [PATCH v1 2/2] net/i40e: " Anatoly Burakov
2021-04-26 14:22 ` David Hunt
2021-04-28 1:22 ` Zhang, Qi Z [this message]
2021-04-26 14:20 ` [dpdk-dev] [PATCH v1 1/2] net/ixgbe: " David Hunt
2021-04-27 1:42 ` Wang, Haiyue
2021-04-28 1:21 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d14731d9c8f46078f5bc453ff416da0@intel.com \
--to=qi.z.zhang@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=beilei.xing@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).