From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Chaoyong He <chaoyong.he@corigine.com>, dev@dpdk.org
Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com,
Peng Zhang <peng.zhang@corigine.com>
Subject: Re: [PATCH] net/nfp: using the correct PCI name to look for the firmware
Date: Wed, 7 Dec 2022 14:45:41 +0000 [thread overview]
Message-ID: <3dd6afb1-6dec-f03d-02ae-7bc14c3936e3@amd.com> (raw)
In-Reply-To: <20221128023705.32671-1-chaoyong.he@corigine.com>
On 11/28/2022 2:37 AM, Chaoyong He wrote:
> From: Peng Zhang <peng.zhang@corigine.com>
>
> In the description of nfp document, DPDK PMD supports that the PF
> looks for a firmware file by the PCI name.
>
> After this commit, it will looks for the PCI name format such as
> pci-0000:04:00.0.nffw rather than pci-04:00.0.nffw, which will
> keep consistent with what is written in the nfp.rst.
>
Hi Chaoyong,
The commit log mentions change is to be consistent with document, but I
assume code is wrong, oterwise it would be easier to update the document.
So, can you please update commit log as a fix to [1]?
[1]
896c265ef954 ("net/nfp: use new CPP interface")
> Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> ---
> drivers/net/nfp/nfp_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
> index 0956ea81df..f22ae24b53 100644
> --- a/drivers/net/nfp/nfp_ethdev.c
> +++ b/drivers/net/nfp/nfp_ethdev.c
> @@ -724,7 +724,7 @@ nfp_fw_upload(struct rte_pci_device *dev, struct nfp_nsp *nsp, char *card)
> goto load_fw;
> /* Then try the PCI name */
> snprintf(fw_name, sizeof(fw_name), "%s/pci-%s.nffw", DEFAULT_FW_PATH,
> - dev->device.name);
> + dev->name);
>
> PMD_DRV_LOG(DEBUG, "Trying with fw file: %s", fw_name);
> if (rte_firmware_read(fw_name, &fw_buf, &fsize) == 0)
next prev parent reply other threads:[~2022-12-07 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 2:37 Chaoyong He
2022-12-07 14:45 ` Ferruh Yigit [this message]
2022-12-08 3:31 ` [PATCH v2] " Chaoyong He
2022-12-08 18:06 ` Ferruh Yigit
2022-12-14 10:45 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dd6afb1-6dec-f03d-02ae-7bc14c3936e3@amd.com \
--to=ferruh.yigit@amd.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).