From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Hernan Vargas <hernan.vargas@intel.com>,
dev@dpdk.org, gakhil@marvell.com, trix@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com
Subject: Re: [PATCH v1 06/13] test/bbdev: log capture from queue stop
Date: Tue, 31 Jan 2023 11:07:00 +0100 [thread overview]
Message-ID: <3e0cf971-d5c7-a603-58e8-739f9a99c460@redhat.com> (raw)
In-Reply-To: <20230117165023.20567-7-hernan.vargas@intel.com>
On 1/17/23 17:50, Hernan Vargas wrote:
> Improve log capture in bbdev not requiring standard output.
>
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
> app/test-bbdev/test_bbdev_perf.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
> index 36ea399938..ffb2de0604 100644
> --- a/app/test-bbdev/test_bbdev_perf.c
> +++ b/app/test-bbdev/test_bbdev_perf.c
> @@ -889,6 +889,7 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info,
> ret = rte_bbdev_queue_configure(ad->dev_id, queue_id,
> &qconf);
> }
> + rte_bbdev_queue_start(ad->dev_id, queue_id);
> if (ret != 0) {
> printf("All queues on dev %u allocated: %u\n",
> dev_id, queue_id);
> @@ -897,8 +898,8 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info,
> ad->queue_ids[queue_id] = queue_id;
> }
> TEST_ASSERT(queue_id != 0,
> - "ERROR Failed to configure any queues on dev %u",
> - dev_id);
> + "ERROR Failed to configure any queues on dev %u\n"
> + "\tthe device may not support or have been configured", dev_id);
> ad->nb_queues = queue_id;
>
> set_avail_op(ad, op_type);
> @@ -3844,6 +3845,7 @@ throughput_pmd_lcore_ldpc_dec(void *arg)
> TEST_ASSERT_SUCCESS(ret, "Validation failed!");
> }
>
> + rte_bbdev_queue_stop(tp->dev_id, queue_id);
The patch is doing more than advertised.
> rte_bbdev_dec_op_free_bulk(ops_enq, num_ops);
>
> double tb_len_bits = calc_ldpc_dec_TB_size(ref_op);
Maxime
next prev parent reply other threads:[~2023-01-31 10:07 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 16:50 [PATCH v1 00/13] test/bbdev: changes for 23.03 Hernan Vargas
2023-01-17 16:50 ` [PATCH v1 01/13] test/bbdev: fix seg fault for non supported HARQ len Hernan Vargas
2023-01-31 9:20 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 02/13] test/bbdev: refactor TB throughput report Hernan Vargas
2023-01-31 9:48 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 03/13] test/bbdev: add timeout for latency tests Hernan Vargas
2023-01-31 10:02 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 04/13] test/bbdev: early termination not explicit set Hernan Vargas
2023-01-31 10:04 ` Maxime Coquelin
2023-02-10 17:15 ` Vargas, Hernan
2023-02-20 15:38 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 05/13] test/bbdev: report device status in bbdev-test Hernan Vargas
2023-01-31 10:05 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 06/13] test/bbdev: log capture from queue stop Hernan Vargas
2023-01-31 10:07 ` Maxime Coquelin [this message]
2023-01-17 16:50 ` [PATCH v1 07/13] test/bbdev: add support for BLER for 4G Hernan Vargas
2023-01-31 10:20 ` Maxime Coquelin
2023-02-13 20:59 ` Vargas, Hernan
2023-02-20 15:43 ` Maxime Coquelin
2023-02-22 21:55 ` Vargas, Hernan
2023-02-23 8:26 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 08/13] test/bbdev: extend support for large TB Hernan Vargas
2023-01-31 11:29 ` Maxime Coquelin
2023-02-13 20:20 ` Vargas, Hernan
2023-02-20 15:40 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 09/13] test/bbdev: bbdev-test cannot compare some scenarios Hernan Vargas
2023-01-31 12:15 ` Maxime Coquelin
2023-02-13 19:40 ` Chautru, Nicolas
2023-01-17 16:50 ` [PATCH v1 10/13] test/bbdev: adjustment for soft output Hernan Vargas
2023-01-31 12:25 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 11/13] test/bbdev: expose warning counters Hernan Vargas
2023-01-31 12:26 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 12/13] test/bbdev: remove check for invalid opaque data Hernan Vargas
2023-01-31 12:33 ` Maxime Coquelin
2023-01-17 16:50 ` [PATCH v1 13/13] test/bbdev: remove iteration count check Hernan Vargas
2023-01-31 12:35 ` Maxime Coquelin
2023-02-08 20:38 ` Vargas, Hernan
2023-02-09 9:10 ` Maxime Coquelin
2023-02-09 16:59 ` Chautru, Nicolas
2023-02-10 14:01 ` Maxime Coquelin
2023-02-10 18:11 ` Chautru, Nicolas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e0cf971-d5c7-a603-58e8-739f9a99c460@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).