From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Tejasree Kondoj <ktejasree@marvell.com>,
Akhil Goyal <gakhil@marvell.com>,
<Jiang@mx0b-0016f401.pphosted.com>, YuX <yux.jiang@intel.com>,
Longfeng Liang <longfengx.liang@intel.com>
Cc: Anoob Joseph <anoobj@marvell.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] common/cnxk: fix build failure
Date: Thu, 28 Oct 2021 18:32:29 +0100 [thread overview]
Message-ID: <3e5fdf2c-fd08-a890-955f-f2bb3a787a9c@intel.com> (raw)
In-Reply-To: <20211027131259.11775-1-ktejasree@marvell.com>
On 10/27/2021 2:12 PM, Tejasree Kondoj wrote:
> Fixing build failure with EXTRA_CFLAGS='-O1'.
>
For future, can you please provide a little more detail in the commit
log related to the build error,
like which compiler or compiler version cause the issue, what is the
build error and put part of the log in commit log that can help to
people searching for the error log.
Plus if the build error is genuine build error, or if you are just
silencing compiler false positive.
> Fixes: d85f9749f915 ("common/cnxk: add hash generation API")
>
> Reported-by: Longfeng Liang <longfengx.liang@intel.com>
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> ---
> drivers/common/cnxk/roc_hash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_hash.c b/drivers/common/cnxk/roc_hash.c
> index 092286e41e..4a34c7fbf8 100644
> --- a/drivers/common/cnxk/roc_hash.c
> +++ b/drivers/common/cnxk/roc_hash.c
> @@ -23,7 +23,7 @@ roc_hash_sha1_gen(uint8_t *msg, uint32_t *hash)
> 0x67452301, 0xEFCDAB89, 0x98BADCFE, 0x10325476,
> 0xC3D2E1F0};
> int i;
> - uint32_t temp; /* Temporary word value */
> + uint32_t temp = 0; /* Temporary word value */
> uint32_t W[80]; /* Word sequence */
> uint32_t A, B, C, D, E; /* Word buffers */
>
>
next prev parent reply other threads:[~2021-10-28 17:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 13:12 Tejasree Kondoj
2021-10-28 7:01 ` Anoob Joseph
2021-10-28 12:59 ` Jerin Jacob
2021-10-28 17:32 ` Ferruh Yigit [this message]
2021-10-29 4:57 ` [dpdk-dev] [EXT] " Tejasree Kondoj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e5fdf2c-fd08-a890-955f-f2bb3a787a9c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Jiang@mx0b-0016f401.pphosted.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=ktejasree@marvell.com \
--cc=longfengx.liang@intel.com \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).