From: "Etelson, Gregory" <getelson@nvidia.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Bruce Richardson" <bruce.richardson@intel.com>,
dev@dpdk.org, <mkashani@nvidia.com>,
rasland@nvidia.com, alialnu@nvidia.com
Subject: Re: [PATCH] cmdline: configure input buffer size
Date: Wed, 1 May 2024 18:56:37 +0300 (IDT) [thread overview]
Message-ID: <3ee37b9c-25f-cf53-5b3-63b736327766@nvidia.com> (raw)
In-Reply-To: <20240501074238.0033d275@hermes.local>
Hello Stephen,
>>> Basic question, what would be the impact of increasing the default from 512
>>> to 1k or 2k? Do we get a large memory footprint increase, or is it just an
>>> extra 1 or 2k of memory used?
>>>
>>> /Bruce
>>>
>>
>> Increasing the RDLINE_BUF_SIZE size will also increase application memory usage.
>> However, that memory increase was required, because application could not fit
>> it's command line into the default buffer.
>>
>> Applications that can run with the default RDLINE_BUF_SIZE are not affected by
>> that patch.
>>
>> Regards,
>> Gregory
>
>
> The buffer is transient so should have little impact.
> Why not just use LINE_MAX from limits.h?
>
The LINE_MAX value will be enough even for the template API testpmd commands.
If there will be no objections, I'll set LINE_MAX as the new
RDLINE_BUF_SIZE.
Regards,
Gregory
next prev parent reply other threads:[~2024-05-01 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 5:26 Gregory Etelson
2024-05-01 9:08 ` Bruce Richardson
2024-05-01 10:06 ` Etelson, Gregory
2024-05-01 14:42 ` Stephen Hemminger
2024-05-01 15:56 ` Etelson, Gregory [this message]
2024-05-01 16:30 ` Bruce Richardson
2024-05-01 17:18 ` [PATCH v2] cmdline: increase " Gregory Etelson
2024-05-01 18:26 ` Morten Brørup
2024-05-02 7:27 ` Bruce Richardson
2024-05-03 4:27 ` [PATCH v3] " Gregory Etelson
2024-05-15 8:41 ` Gregory Etelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ee37b9c-25f-cf53-5b3-63b736327766@nvidia.com \
--to=getelson@nvidia.com \
--cc=alialnu@nvidia.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=mkashani@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).