From: Akhil Goyal <akhil.goyal@nxp.com>
To: Abhinandan Gujjar <abhinandan.gujjar@intel.com>,
jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com,
dev@dpdk.org
Cc: pablo.de.lara.guarch@intel.com, declan.doherty@intel.com,
narender.vangati@intel.com, nikhil.rao@intel.com
Subject: Re: [dpdk-dev] [dpdk-dev, v1, 5/5] doc: add event crypto adapter documentation
Date: Mon, 16 Apr 2018 20:18:24 +0530 [thread overview]
Message-ID: <3f456621-ff31-ced8-f399-7e19e01ffdf3@nxp.com> (raw)
In-Reply-To: <1522825047-61743-1-git-send-email-abhinandan.gujjar@intel.com>
Hi Abhinandan,
On 4/4/2018 12:27 PM, Abhinandan Gujjar wrote:
> Add entries in the programmer's guide, API index, maintainer's file
> and release notes for the event crypto adapter.
>
> Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> ---
[.snip.]
> +
> +Set event request/response information
> +--------------------------------------
> +
> +In the ENQ_DEQ mode, the application needs to specify the cryptodev ID
> +and queue pair ID (request information) in addition to the event
> +information (response information) needed to enqueue an event after
> +the crypto operation has completed. The request and response information
> +are specified in the ``struct rte_crypto_op`` private data or session's
> +private data.
> +
> +In the DEQ mode, the application is required to provide only the
> +response information.
> +
> +The SW adapter or HW PMD uses ``rte_crypto_op::sess_type`` to
> +decide whether request/response data is located in the crypto session/
> +crypto security session or at an offset in the ``struct rte_crypto_op``.
> +The ``rte_crypto_op::private_data_offset`` is used to locate the request/
> +response in the ``rte_crypto_op``.
> +
> +For crypto session, ``rte_cryptodev_sym_session_set_private_data()`` API
> +will be used to set request/response data. The same data will be obtained
> +by ``rte_cryptodev_sym_session_get_private_data()`` API.
> +
> +For security session, ``rte_security_session_set_private_data()`` API
> +will be used to set request/response data. The same data will be obtained
> +by ``rte_security_session_get_private_data()`` API.
I think you have missed this security API in your patches.
Also I don't think this methodology for adding the private data in
session will work in case of security sessions. As we have only one API
for creating/configuring the security session. However, we can add a
parameter in the rte_security_session_create(). Since this API is still
experimental, we can change the parameters. What Say?
-Akhil
next prev parent reply other threads:[~2018-04-16 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 6:57 Abhinandan Gujjar
2018-04-16 14:48 ` Akhil Goyal [this message]
2018-05-11 13:36 ` Gujjar, Abhinandan S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f456621-ff31-ced8-f399-7e19e01ffdf3@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=abhinandan.gujjar@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=narender.vangati@intel.com \
--cc=nikhil.rao@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).