From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Gregory Etelson <getelson@nvidia.com>, dev@dpdk.org
Cc: mkashani@nvidia.com, stable@dpdk.org, Ori Kam <orika@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Olga Shern <olgas@nvidia.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH] app/testpmd: add size validation to token parsers
Date: Thu, 8 Feb 2024 14:45:01 +0000 [thread overview]
Message-ID: <3f88502b-2434-4ed2-a3bb-8fde626d44f4@amd.com> (raw)
In-Reply-To: <20231111071347.71824-1-getelson@nvidia.com>
On 11/11/2023 7:13 AM, Gregory Etelson wrote:
> parse_prefix(), parse_int(), parse_mac_addr(),
> parse_ipv4_addr() and parse_ipv6_addr() unconditionally overwrite
> the `size` parameter with token size.
> The `size` parameter references a buffer where the parser functions
> will store their result.
>
> If the `size` value was less than token size, parser will corrupt
> memory outsite of target buffer.
>
> The patch adds sizes validation.
>
> Fixes: d3f61b7bad20 ("app/testpmd: add flow item spec prefix length")
> Fixes: 8a03ab58cc0a ("app/testpmd: support flow integer")
> Fixes: 6df81b325fa4 ("app/testpmd: add items eth/vlan to flow command")
> Fixes: ef6e38550f07 ("app/testpmd: add items ipv4/ipv6 to flow command")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
next prev parent reply other threads:[~2024-02-08 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 7:13 Gregory Etelson
2024-02-08 14:45 ` Ferruh Yigit [this message]
2024-02-09 15:07 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f88502b-2434-4ed2-a3bb-8fde626d44f4@amd.com \
--to=ferruh.yigit@amd.com \
--cc=adrien.mazarguil@6wind.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=olgas@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).