From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Junjie Lin <277600718@qq.com>
Cc: <dev@dpdk.org>, <linjunjie6@huawei.com>, <xuanziyang2@huawei.com>,
<zhouguoyang@huawei.com>
Subject: Re: [PATCH] net/hinic: fix Tx mbuf length problem
Date: Tue, 8 Mar 2022 11:16:37 +0000 [thread overview]
Message-ID: <3fbecc49-9851-a0e3-473a-af00a60421d8@intel.com> (raw)
In-Reply-To: <20220307080602.09340804@hermes.local>
On 3/7/2022 4:06 PM, Stephen Hemminger wrote:
> On Mon, 7 Mar 2022 22:12:20 +0800
> Junjie Lin <277600718@qq.com> wrote:
>
>> From: Junjie Lin <linjunjie6@huawei.com>
>>
>> The Tx mbuf needs to be ignored if the pkt_len member is zero.
>>
>> Fixes: 54faba2295bd ("net/hinic:adds Tx queue xstats members")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Junjie Lin <linjunjie6@huawei.com>
>
> Not all drivers do this. It looks like you have a buggy application
> if it tries to send 0 length packets.
Agree, not sure if invalid packet check should be done in driver level.
Junjie, in which use case you are observing this problem?
Or in the past, I remember some PMD FW was crashing for similar
case, and check was added to protect device, do you have similar
problem?
prev parent reply other threads:[~2022-03-08 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 14:12 Junjie Lin
2022-03-07 16:06 ` Stephen Hemminger
2022-03-08 11:16 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fbecc49-9851-a0e3-473a-af00a60421d8@intel.com \
--to=ferruh.yigit@intel.com \
--cc=277600718@qq.com \
--cc=dev@dpdk.org \
--cc=linjunjie6@huawei.com \
--cc=stephen@networkplumber.org \
--cc=xuanziyang2@huawei.com \
--cc=zhouguoyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).