From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: abhimanyu.saini@xilinx.com, dev@dpdk.org
Cc: chenbo.xia@intel.com, maxime.coquelin@redhat.com,
stable@dpdk.org, Abhimanyu Saini <absaini@amd.com>,
Vijay Kumar Srivastava <vsrivast@xilinx.com>
Subject: Re: [PATCH] vdpa/sfc: handle sync issue between qemu and vhost-user
Date: Mon, 27 Jun 2022 18:03:50 +0300 [thread overview]
Message-ID: <3fc73f93-5248-2fd5-2779-04047ae0b750@oktetlabs.ru> (raw)
In-Reply-To: <20220627084917.2295-1-asaini@xilinx.com>
When you send a new version, please, don't forget to specify
-v <next-version-number> on part format and use --in-reply-to
with the first mail ID. See contributors guidelines.
Also, new version should make it clear what is changed. See below.
On 6/27/22 11:49, abhimanyu.saini@xilinx.com wrote:
> From: Abhimanyu Saini <absaini@amd.com>
>
> When DPDK app is running in the VF, it sometimes rings the doorbell
> before dev_config has had a chance to complete and hence it misses
> the event. As workaround, ring the doorbell when vDPA reports the
> notify_area to QEMU.
>
> Fixes: 5e7596ba7cb3 ("vdpa/sfc: introduce Xilinx vDPA driver")
Above seems to be wrong. Nearby code is added later, so, it should be:
Fixes: 630be406dcbf ("vdpa/sfc: get queue notify area info")
> Cc: stable@dpdk.org
>
> Signed-off-by: Vijay Kumar Srivastava <vsrivast@xilinx.com>
> Signed-off-by: Abhimanyu Saini <absaini@amd.com>
> ---
Version changelog here.
> drivers/vdpa/sfc/sfc_vdpa_ops.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c
> index b3d9b6c..63aa52d 100644
> --- a/drivers/vdpa/sfc/sfc_vdpa_ops.c
> +++ b/drivers/vdpa/sfc/sfc_vdpa_ops.c
> @@ -794,6 +794,8 @@
> int vfio_dev_fd;
> efx_rc_t rc;
> unsigned int bar_offset;
> + volatile void *doorbell;
> + struct rte_pci_device *pci_dev;
> struct rte_vdpa_device *vdpa_dev;
> struct sfc_vdpa_ops_data *ops_data;
> struct vfio_region_info reg = { .argsz = sizeof(reg) };
> @@ -856,6 +858,18 @@
> sfc_vdpa_info(dev, "vDPA ops get_notify_area :: offset : 0x%" PRIx64,
> *offset);
>
> + pci_dev = sfc_vdpa_adapter_by_dev_handle(dev)->pdev;
> + doorbell = (uint8_t *)pci_dev->mem_resource[reg.index].addr + *offset;
> +
> + /*
> + * virtio-net driver in VM sends queue notifications before
> + * vDPA has a chance to setup the queues and notification area,
> + * and hence the HW misses these doorbell notifications.
> + * Since, it is safe to send duplicate doorbell, send another
> + * doorbell from vDPA driver as workaround for this timing issue.
> + */
> + rte_write16(qid, doorbell);
> +
> return 0;
> }
>
next prev parent reply other threads:[~2022-06-27 15:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 8:49 abhimanyu.saini
2022-06-27 15:03 ` Andrew Rybchenko [this message]
2022-06-28 5:29 ` [PATCH v2] " abhimanyu.saini
2022-06-28 9:01 ` Andrew Rybchenko
2022-06-30 12:56 ` Maxime Coquelin
2022-07-01 13:58 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fc73f93-5248-2fd5-2779-04047ae0b750@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=abhimanyu.saini@xilinx.com \
--cc=absaini@amd.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=vsrivast@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).