From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: increase length device internal name
Date: Tue, 10 Oct 2017 00:12:16 +0100 [thread overview]
Message-ID: <40111fb2-af2a-6015-9dab-37a59f4e5894@intel.com> (raw)
In-Reply-To: <20170927092320.6837-1-stephen@networkplumber.org>
On 9/27/2017 10:23 AM, Stephen Hemminger wrote:
> Allow sufficicent space for UUID in string form (36+1).
> Needed to use UUID with Hyper-V. This was in deprecation notice
> for previous release and make it so in 17.11.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Except from below note,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 3 +++
> lib/librte_eal/common/include/rte_dev.h | 6 +++++-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 3362f33501dd..ba5b68e70098 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -120,3 +120,6 @@ Deprecation Notices
> The non-"do-sig" versions of the hash tables will be removed
> (including the ``signature_offset`` parameter)
> and the "do-sig" versions renamed accordingly.
> +
> +* ethdev: in 17.11 the size of internal device name is increased
> + to 64 characters to allow for storing longer bus specific name.
There is already a deprecation notice added in previous release for this
release. Since this patch implements it, notice should be removed,
instead of adding new one.
> diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h
> index 5386d3a28be5..4c4ac7e5d375 100644
> --- a/lib/librte_eal/common/include/rte_dev.h
> +++ b/lib/librte_eal/common/include/rte_dev.h
> @@ -152,7 +152,11 @@ struct rte_driver {
> const char *alias; /**< Driver alias. */
> };
>
> -#define RTE_DEV_NAME_MAX_LEN (32)
> +/*
> + * Internal identifier length
> + * Sufficiently large to allow for UUID or PCI address
> + */
> +#define RTE_DEV_NAME_MAX_LEN 64
>
> /**
> * A structure describing a generic device.
>
next prev parent reply other threads:[~2017-10-09 23:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 9:23 Stephen Hemminger
2017-10-09 23:12 ` Ferruh Yigit [this message]
2017-10-09 23:14 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40111fb2-af2a-6015-9dab-37a59f4e5894@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).