From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Raslan Darawsheh <rasland@mellanox.com>, Gavin Hu <gavin.hu@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"xiaolong.ye@intel.com" <xiaolong.ye@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
"Ruifeng.Wang@arm.com" <Ruifeng.Wang@arm.com>,
"Phil.Yang@arm.com" <Phil.Yang@arm.com>,
"Joyce.Kong@arm.com" <Joyce.Kong@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [patch v1] net/i40e: fix the compile issue
Date: Tue, 21 Apr 2020 12:56:07 +0100 [thread overview]
Message-ID: <401c882d-3808-ffa5-3414-99db562a8d6c@intel.com> (raw)
In-Reply-To: <AM0PR05MB67070F437592A6CD95189818C2D50@AM0PR05MB6707.eurprd05.prod.outlook.com>
On 4/21/2020 12:06 PM, Raslan Darawsheh wrote:
> Hi,
>
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Tuesday, April 21, 2020 12:51 PM
>> To: Gavin Hu <gavin.hu@arm.com>; Raslan Darawsheh
>> <rasland@mellanox.com>
>> Cc: dev@dpdk.org; xiaolong.ye@intel.com; david.marchand@redhat.com;
>> Thomas Monjalon <thomas@monjalon.net>;
>> Honnappa.Nagarahalli@arm.com; Ruifeng.Wang@arm.com;
>> Phil.Yang@arm.com; Joyce.Kong@arm.com; stable@dpdk.org
>> Subject: Re: [patch v1] net/i40e: fix the compile issue
>>
>> On 4/21/2020 10:49 AM, Gavin Hu wrote:
>>> Using gcc version 4.8.5 20150623 (Red Hat 4.8.5-28), it reports the
>>> following compiling error:
>>>
>>> /download/dpdk/drivers/net/i40e/i40e_rxtx_vec_neon.c:175:65: error:
>>> expected ';', ',' or ')' before 'rx_pkts' desc_to_ptype_v(uint64x2_t
>>> descs[4], struct rte_mbuf **restrict rx_pkts, ^
>>> /download/dpdk/drivers/net/i40e/i40e_rxtx_vec_neon.c:197:51: error:
>>> expected ';', ',' or ')' before 'rxq' _recv_raw_pkts_vec(struct
>>> i40e_rx_queue *restrict rxq, struct rte_mbuf ^
>>> /download/dpdk/drivers/net/i40e/i40e_rxtx_vec_neon.c:435:35: error:
>>> expected ';', ',' or ')' before 'rx_queue' i40e_recv_pkts_vec(void
>>> *restrict rx_queue, struct rte_mbuf **restrict rx_pkts,
>>>
>>> Fix this by using '__restrict' type qualifier, which compiles ok with
>>> old and new versions of gcc.
>>>
>>> Fixes: 8499b1748f26 ("net/i40e: restrict pointer aliasing for NEON")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Tested-by: Raslan Darawsheh <rasland@mellanox.com>
>>
>> Thanks Gavin.
>>
>> Raslan can you please test the patch since you can reproduce the issue?
>>
>> Thanks,
>> ferruh
>
> Just verified it's working just fine with this fix, thanks for that.
>
Squashed into relevant commit in next-net, thanks.
prev parent reply other threads:[~2020-04-21 11:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 9:49 Gavin Hu
2020-04-21 9:51 ` Ferruh Yigit
2020-04-21 11:06 ` Raslan Darawsheh
2020-04-21 11:56 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=401c882d-3808-ffa5-3414-99db562a8d6c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Joyce.Kong@arm.com \
--cc=Phil.Yang@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).