From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: "Abdullah Ömer Yamaç" <aomeryamac@gmail.com>,
"Honnappa Nagarahalli" <honnappa.nagarahalli@arm.com>,
"Yipeng Wang" <yipeng1.wang@intel.com>,
"Sameh Gobriel" <sameh.gobriel@intel.com>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Vladimir Medvedkin" <vladimir.medvedkin@intel.com>,
"Abdullah Ömer Yamaç" <aomeryamac@gmail.com>
Subject: Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash
Date: Fri, 16 Feb 2024 13:41:59 +0100 [thread overview]
Message-ID: <40388235.10thIPus4b@thomas> (raw)
In-Reply-To: <20240207153340.34146-1-aomeryamac@gmail.com>
Any review please?
07/02/2024 16:33, Abdullah Ömer Yamaç:
> This patch introduce a new API to get the hidden key count in the hash
> table if the rcu qsbr is enabled. When using rte_hash_count with rcu
> qsbr enabled, it will return the number of elements that are not in the
> free queue. Unless rte_rcu_qsbr_dq_reclaim is called, the number of
> elements in the defer queue will not be counted and freed. Therefore I
> added a new API to get the number of hidden (defer queue) elements
> in the hash table. Then the user can calculate the total number of
> elements that are available in the hash table.
>
> Signed-off-by: Abdullah Ömer Yamaç <aomeryamac@gmail.com>
>
> ---
> Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Cc: Yipeng Wang <yipeng1.wang@intel.com>
> Cc: Sameh Gobriel <sameh.gobriel@intel.com>
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> ---
> lib/hash/rte_cuckoo_hash.c | 9 +++++++++
> lib/hash/rte_hash.h | 13 +++++++++++++
> lib/hash/version.map | 1 +
> lib/rcu/rte_rcu_qsbr.c | 8 ++++++++
> lib/rcu/rte_rcu_qsbr.h | 11 +++++++++++
> lib/rcu/version.map | 1 +
> 6 files changed, 43 insertions(+)
>
> diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
> index 70456754c4..3553f3efc7 100644
> --- a/lib/hash/rte_cuckoo_hash.c
> +++ b/lib/hash/rte_cuckoo_hash.c
> @@ -555,6 +555,15 @@ rte_hash_max_key_id(const struct rte_hash *h)
> return h->entries;
> }
>
> +int32_t
> +rte_hash_dq_count(const struct rte_hash *h)
> +{
> + if (h->dq == NULL)
> + return -EINVAL;
> +
> + return rte_rcu_qsbr_dq_count(h->dq);
> +}
> +
> int32_t
> rte_hash_count(const struct rte_hash *h)
> {
> diff --git a/lib/hash/rte_hash.h b/lib/hash/rte_hash.h
> index 7ecc021111..8ea97e297d 100644
> --- a/lib/hash/rte_hash.h
> +++ b/lib/hash/rte_hash.h
> @@ -193,6 +193,19 @@ rte_hash_free(struct rte_hash *h);
> void
> rte_hash_reset(struct rte_hash *h);
>
> +
> +/**
> + * Return the number of records in the defer queue of the hash table
> + * if RCU is enabled.
> + * @param h
> + * Hash table to query from
> + * @return
> + * - -EINVAL if parameters are invalid
> + * - A value indicating how many records were inserted in the table.
> + */
> +int32_t
> +rte_hash_dq_count(const struct rte_hash *h);
> +
> /**
> * Return the number of keys in the hash table
> * @param h
> diff --git a/lib/hash/version.map b/lib/hash/version.map
> index 6b2afebf6b..7f7b158cf1 100644
> --- a/lib/hash/version.map
> +++ b/lib/hash/version.map
> @@ -9,6 +9,7 @@ DPDK_24 {
> rte_hash_add_key_with_hash;
> rte_hash_add_key_with_hash_data;
> rte_hash_count;
> + rte_hash_dq_count;
> rte_hash_crc32_alg;
> rte_hash_crc_set_alg;
> rte_hash_create;
> diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c
> index bd0b83be0c..89f8da4c4c 100644
> --- a/lib/rcu/rte_rcu_qsbr.c
> +++ b/lib/rcu/rte_rcu_qsbr.c
> @@ -450,6 +450,14 @@ rte_rcu_qsbr_dq_reclaim(struct rte_rcu_qsbr_dq *dq, unsigned int n,
> return 0;
> }
>
> +/**
> + * Return the number of entries in a defer queue.
> + */
> +unsigned int rte_rcu_qsbr_dq_count(struct rte_rcu_qsbr_dq *dq)
> +{
> + return rte_ring_count(dq->r);
> +}
> +
> /* Delete a defer queue. */
> int
> rte_rcu_qsbr_dq_delete(struct rte_rcu_qsbr_dq *dq)
> diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h
> index 23c9f89805..ed5a590edd 100644
> --- a/lib/rcu/rte_rcu_qsbr.h
> +++ b/lib/rcu/rte_rcu_qsbr.h
> @@ -794,6 +794,17 @@ int
> rte_rcu_qsbr_dq_reclaim(struct rte_rcu_qsbr_dq *dq, unsigned int n,
> unsigned int *freed, unsigned int *pending, unsigned int *available);
>
> +/**
> + * Return the number of entries in a defer queue.
> + *
> + * @param dq
> + * Defer queue.
> + * @return
> + * The number of entries in the defer queue.
> + */
> +unsigned int
> +rte_rcu_qsbr_dq_count(struct rte_rcu_qsbr_dq *dq);
> +
> /**
> * Delete a defer queue.
> *
> diff --git a/lib/rcu/version.map b/lib/rcu/version.map
> index 982ffd59d9..f410ab41e7 100644
> --- a/lib/rcu/version.map
> +++ b/lib/rcu/version.map
> @@ -5,6 +5,7 @@ DPDK_24 {
> rte_rcu_qsbr_dq_create;
> rte_rcu_qsbr_dq_delete;
> rte_rcu_qsbr_dq_enqueue;
> + rte_rcu_qsbr_dq_count;
> rte_rcu_qsbr_dq_reclaim;
> rte_rcu_qsbr_dump;
> rte_rcu_qsbr_get_memsize;
>
next prev parent reply other threads:[~2024-02-16 12:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 15:33 Abdullah Ömer Yamaç
2024-02-16 12:41 ` Thomas Monjalon [this message]
2024-02-19 17:36 ` Medvedkin, Vladimir
2024-02-19 21:28 ` Abdullah Ömer Yamaç
2024-02-19 23:35 ` Honnappa Nagarahalli
2024-02-20 18:58 ` Abdullah Ömer Yamaç
2024-02-21 3:23 ` Honnappa Nagarahalli
2024-02-21 21:51 ` Abdullah Ömer Yamaç
2024-02-22 2:37 ` Honnappa Nagarahalli
2024-02-22 12:39 ` Abdullah Ömer Yamaç
2024-02-22 16:44 ` Honnappa Nagarahalli
2024-02-28 11:44 ` Abdullah Ömer Yamaç
2024-02-28 14:51 ` Honnappa Nagarahalli
2024-03-02 20:22 ` Abdullah Ömer Yamaç
2024-03-02 21:08 ` [PATCH v2] lib/hash: feature reclaim defer queue Abdullah Ömer Yamaç
2024-03-02 21:27 ` Abdullah Ömer Yamaç
2024-03-03 19:14 ` Honnappa Nagarahalli
2024-03-04 8:27 ` Abdullah Ömer Yamaç
2024-03-04 21:58 ` Honnappa Nagarahalli
2024-03-06 8:55 ` [PATCH v3] lib/hash: add defer queue reclaim API Abdullah Ömer Yamaç
2024-03-06 8:59 ` Abdullah Ömer Yamaç
2024-03-06 10:13 ` Abdullah Ömer Yamaç
2024-03-14 7:04 ` Abdullah Ömer Yamaç
2024-04-04 10:11 ` Abdullah Ömer Yamaç
2024-04-05 2:11 ` Honnappa Nagarahalli
2024-04-15 11:26 ` [PATCH v4] " Abdullah Ömer Yamaç
2024-04-23 13:49 ` Abdullah Ömer Yamaç
2024-04-23 21:24 ` Stephen Hemminger
2024-04-25 14:03 ` Abdullah Ömer Yamaç
2024-04-27 19:54 ` [PATCH v5] " Abdullah Ömer Yamaç
2024-05-10 3:05 ` Abdullah Ömer Yamaç
2024-05-13 5:24 ` Honnappa Nagarahalli
2024-05-13 15:34 ` Abdullah Ömer Yamaç
2024-05-15 10:49 ` Abdullah Ömer Yamaç
2024-05-15 10:54 ` [PATCH v6] " Abdullah Ömer Yamaç
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40388235.10thIPus4b@thomas \
--to=thomas@monjalon.net \
--cc=aomeryamac@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=sameh.gobriel@intel.com \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).