From: Thomas Monjalon <thomas@monjalon.net>
To: Seth Howell <seth.howell@intel.com>
Cc: stable@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
dev@dpdk.org, Darek Stojaczyk <dariusz.stojaczyk@intel.com>,
ktraynor@redhat.com
Subject: Re: [dpdk-stable] [PATCH v2] malloc: notify primary process about hotplug in secondary
Date: Thu, 20 Dec 2018 15:26:56 +0100 [thread overview]
Message-ID: <4046247.fkW2E6NNR7@xps> (raw)
In-Reply-To: <0f7b6cfb-e7d0-b511-b943-7f1b3b3eda2f@intel.com>
10/12/2018 11:49, Burakov, Anatoly:
> On 07-Dec-18 8:10 PM, Seth Howell wrote:
> > When secondary process hotplugs memory, it sends a request
> > to primary, which then performs the real mmap() and sends
> > sync requests to all secondary processes. Upon receiving
> > such sync request, each secondary process will notify the
> > upper layers of hotplugged memory (and will call all
> > locally registered event callbacks).
> >
> > In the end we'll end up with memory event callbacks fired
> > in all the processes except the primary, which is a bug.
> >
> > This gets critical if memory is hotplugged while a VFIO
> > device is attached, as the VFIO memory registration -
> > which is done from a memory event callback present in the
> > primary process only - is never called.
> >
> > After this patch, a primary process fires memory event
> > callbacks before secondary processes start their
> > synchronizations - both for hotplug and hotremove.
> >
> > Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug")
> >
> > Signed-off-by: Seth Howell <seth.howell@intel.com>
> > Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> > ---
>
> Lost my review tag...
>
> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
+Cc: stable@dpdk.org
Applied, thanks
prev parent reply other threads:[~2018-12-20 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181204170610.250124-1-seth.howell@intel.com>
2018-12-07 20:06 ` [dpdk-stable] [PATCH] " Seth Howell
2018-12-07 20:10 ` [dpdk-stable] [PATCH v2] " Seth Howell
2018-12-07 20:30 ` Stojaczyk, Dariusz
2018-12-08 17:02 ` Kevin Traynor
2018-12-20 14:24 ` Thomas Monjalon
2018-12-10 10:49 ` Burakov, Anatoly
2018-12-20 14:26 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4046247.fkW2E6NNR7@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=seth.howell@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).