From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"alialnu@nvidia.com" <alialnu@nvidia.com>,
"aconole@redhat.com" <aconole@redhat.com>,
"ci@dpdk.org" <ci@dpdk.org>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Subject: Re: [EXT] Re: [PATCH] pw_maintainers_cli: enhance tree selection
Date: Fri, 29 Sep 2023 13:09:33 +0200 [thread overview]
Message-ID: <4092421.X513TT2pbd@thomas> (raw)
In-Reply-To: <PH0PR18MB4086E4FFDB2C1FBF7931AFB3DEC0A@PH0PR18MB4086.namprd18.prod.outlook.com>
29/09/2023 12:54, Pavan Nikhilesh Bhagavatula:
> > > From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> > > > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > > >
> > > > When longest prefix match doesnt find a suitable tree, pick the
> > > > tree which has the highest modified file count instead of defauting
> > > > to main tree.
> > > >
> > >
> > > This change is need to find the correct branch when a patch has a
> > specification
> > > Change followed by a implementation of driver layer example:
> > >
> > > https://urldefense.proofpoint.com/v2/url?u=https-
> > 3A__patches.dpdk.org_project_dpdk_list_-3Fseries-
> > 3D29675&d=DwICAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=E3SgYMjtKCMVsB-
> > fmvgGV3o-g_fjLhk5Pupi9ijohpc&m=WKN1erKSjH9MuEyyRs-
> > R3jYC5geZeUeNipx2GQlQpQSuQQCet70Torr1oSdZNvZp&s=6XFs2Ggg5G0VFd
> > YEaRexumEXM5JKc2vs5dmrRNcIUZw&e=
> >
> > That's expected: when a series touches more than a tree scope,
> > it goes to main.
> > But that's not the issue here.
> > Both eventdev lib, test and drivers belong to the eventdev tree.
> > So why it is not already delegated to eventdev?
> > Please dig more.
> >
> >
>
> The main issue is the driver implementation touches common/cnxk which ties it to
> next-net-mrvl tree which causes the conflict.
>
> We have few options here,
> 1. Based on max number of files touched per tree (Current patch)
> 2. Ignore driver/common from tree selection when there is a conflict with other tree.
> 3. When there is a conflict between trees choose the common tree instead of company specific tree
> Example, dpdk-next-eventdev + dpdk-next-net-mrvl = dpdk-next-eventdev
I have a preference for option 2.
next prev parent reply other threads:[~2023-09-29 11:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 8:34 pbhagavatula
2023-09-29 9:21 ` Pavan Nikhilesh Bhagavatula
2023-09-29 9:40 ` David Marchand
2023-09-29 10:16 ` [EXT] " Pavan Nikhilesh Bhagavatula
2023-09-29 10:21 ` Thomas Monjalon
2023-09-29 10:54 ` [EXT] " Pavan Nikhilesh Bhagavatula
2023-09-29 11:09 ` Thomas Monjalon [this message]
2023-09-29 11:13 ` Jerin Jacob Kollanukkaran
2023-09-29 13:17 ` [PATCH v2] pw_maintainers_cli: enhance ci " pbhagavatula
2023-10-12 12:59 ` Aaron Conole
2023-10-13 5:55 ` [EXT] " Pavan Nikhilesh Bhagavatula
2023-12-07 13:33 ` Pavan Nikhilesh Bhagavatula
2023-12-07 13:44 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4092421.X513TT2pbd@thomas \
--to=thomas@monjalon.net \
--cc=aconole@redhat.com \
--cc=alialnu@nvidia.com \
--cc=ci@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).