From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: stable@dpdk.org, dev@dpdk.org, Ravi1.Kumar@amd.com
Subject: Re: [dpdk-stable] [PATCH v2] eal/linuxapp: improve segment list preallocation
Date: Mon, 22 Oct 2018 12:32:20 +0200 [thread overview]
Message-ID: <4093296.dHmcqor6Pu@xps> (raw)
In-Reply-To: <5e545d6548f62a8fddfca18f8cc0901654e1e403.1538728009.git.anatoly.burakov@intel.com>
05/10/2018 10:29, Anatoly Burakov:
> Current code to preallocate segment lists is trying to do
> everything in one go, and thus ends up being convoluted,
> hard to understand, and, most importantly, does not scale beyond
> initial assumptions about number of NUMA nodes and number of
> page sizes, and therefore has issues on some configurations.
>
> Instead of fixing these issues in the existing code, simply
> rewrite it to be slightly less clever but much more logical, and
> provide ample comments to explain exactly what is going on.
>
> We cannot use the same approach for 32-bit code because the
> limitations of the target dictate current socket-centric
> approach rather than type-centric approach we use on 64-bit
> target, so 32-bit code is left unmodified. FreeBSD doesn't
> support NUMA so there's no complexity involved there, and thus
> its code is much more readable and not worth changing.
>
> Fixes: 1d406458db47 ("mem: make segment preallocation OS-specific")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-10-22 10:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 16:13 [dpdk-stable] [PATCH] " Anatoly Burakov
2018-10-05 8:29 ` [dpdk-stable] [PATCH v2] " Anatoly Burakov
2018-10-22 10:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4093296.dHmcqor6Pu@xps \
--to=thomas@monjalon.net \
--cc=Ravi1.Kumar@amd.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).