DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Amr Mokhtar <amr.mokhtar@intel.com>, dev@dpdk.org
Cc: thomas@monjalon.net, anatoly.burakov@intel.com,
	pablo.de.lara.guarch@intel.com, niall.power@intel.com,
	chris.macnamara@intel.com
Subject: Re: [dpdk-dev] [PATCH v3 3/5] bbdev: test applications
Date: Mon, 11 Dec 2017 11:01:27 -0800	[thread overview]
Message-ID: <409ed602-6bc4-d2e2-488d-5c512586173f@intel.com> (raw)
In-Reply-To: <1512682857-79467-3-git-send-email-amr.mokhtar@intel.com>

On 12/7/2017 1:40 PM, Amr Mokhtar wrote:
> - Full test suite for bbdev
> - Test App works seamlessly on all PMDs registered with bbdev
>  framework
> - A python script is provided to make our life easier

Can you please describe what the script is for?

> - Supports execution of tests by parsing Test Vector files

Can you please describe what are test vector files?

> - Test Vectors can be added/deleted/modified with no need for
>  re-compilation
> - Various Tests can be executed:
>  (a) Throughput test
>  (b) Offload latency test
>  (c) Operation latency test
>  (d) Validation test
>  (c) Sanity checks
> 
> Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>

<...>

> +include $(RTE_SDK)/mk/rte.vars.mk
> +
> +ifeq ($(CONFIG_RTE_TEST_BBDEV),y)

You don't need this ifdef I think, although I can see testpmd has it ...

> +
> +#
> +# library name
> +#
> +APP = testbbdev
> +
> +CFLAGS += -O3
> +CFLAGS += $(WERROR_FLAGS)
> +
> +#
> +# all sources are stored in SRCS-y
> +#
> +SRCS-$(CONFIG_RTE_LIBRTE_BBDEV) += main.c
> +SRCS-$(CONFIG_RTE_LIBRTE_BBDEV) += test_bbdev.c
> +SRCS-$(CONFIG_RTE_LIBRTE_BBDEV) += test_bbdev_perf.c
> +SRCS-$(CONFIG_RTE_LIBRTE_BBDEV) += test_bbdev_vector.c

If you remove above wrapping ifdef, you may use CONFIG_RTE_TEST_BBDEV instead.

<...>

> +int
> +unit_test_suite_runner(struct unit_test_suite *suite)

Is test-bbdev application a suit of test cases? What is the benefit of having
separate application comparing adding unit tests to test/ folder?

<...>

  reply	other threads:[~2017-12-11 19:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 21:40 [dpdk-dev] [PATCH v3 1/5] bbdev: librte_bbdev library Amr Mokhtar
2017-12-07 21:40 ` [dpdk-dev] [PATCH v3 2/5] bbdev: PMD drivers (null/turbo_sw) Amr Mokhtar
2017-12-11 19:00   ` Ferruh Yigit
2017-12-19 19:09     ` Mokhtar, Amr
2017-12-07 21:40 ` [dpdk-dev] [PATCH v3 3/5] bbdev: test applications Amr Mokhtar
2017-12-11 19:01   ` Ferruh Yigit [this message]
2017-12-23  0:09     ` Mokhtar, Amr
2017-12-07 21:40 ` [dpdk-dev] [PATCH v3 4/5] bbdev: sample app Amr Mokhtar
2017-12-07 21:40 ` [dpdk-dev] [PATCH v3 5/5] bbdev: documentation Amr Mokhtar
2017-12-11 19:01   ` Ferruh Yigit
2017-12-19 19:34     ` Mokhtar, Amr
2017-12-18 14:26   ` Kovacevic, Marko
2017-12-23  0:11     ` Mokhtar, Amr
2017-12-07 21:40 ` [dpdk-dev] [PATCH v3 0/5] Wireless Baseband Device (bbdev) Amr Mokhtar
2017-12-09  2:44 ` [dpdk-dev] [PATCH v3 1/5] bbdev: librte_bbdev library Ferruh Yigit
2017-12-19 19:03   ` Mokhtar, Amr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=409ed602-6bc4-d2e2-488d-5c512586173f@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=amr.mokhtar@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=chris.macnamara@intel.com \
    --cc=dev@dpdk.org \
    --cc=niall.power@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).