From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jens Freimann <jfreimann@redhat.com>, dev@dpdk.org
Cc: ailan@redhat.com, jan.scheurich@ericsson.com,
vkaplans@redhat.com, bruce.richardson@intel.com,
thomas@monjalon.net, maxime.coquelin@redhat.com,
konstantin.ananyev@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 2/2] testpmd: update testpmd documentation to include noisy forwarding mode
Date: Fri, 13 Apr 2018 14:19:28 +0100 [thread overview]
Message-ID: <40abbbc6-911f-163c-a18f-2433e4cee48c@intel.com> (raw)
In-Reply-To: <20180413113716.27968-3-jfreimann@redhat.com>
On 4/13/2018 12:37 PM, Jens Freimann wrote:
> Signed-off-by: Jens Freimann <jfreimann@redhat.com>
> ---
> doc/guides/testpmd_app_ug/run_app.rst | 27 +++++++++++++++++++++++++++
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++++--
> 2 files changed, 32 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst
> index 1fd53958a..0b7046bb0 100644
> --- a/doc/guides/testpmd_app_ug/run_app.rst
> +++ b/doc/guides/testpmd_app_ug/run_app.rst
> @@ -340,6 +340,7 @@ The commandline options are:
> icmpecho
> ieee1588
> tm
> + noisy
>
> * ``--rss-ip``
>
> @@ -479,3 +480,29 @@ The commandline options are:
>
> Set the hexadecimal bitmask of TX queue offloads.
> The default value is 0.
> +
> +* ``--buffersize-before-sending=N``
> +
> + Set the number of maximum elements of the FIFO queue to be created
> + for buffering packets. Only available with the noisy forwarding mode.
> + The default value is 0.
> +
> +* ``--flush-timeout=N``
> +
> + Set the size of the FIFO queue to be created for buffering packets.
> + Only available with the noisy forwarding mode. The default value is 0.
Some of the there parameter names are so generic when you think them in the
scope of the whole testpmd it can be confusing and hard to understand what they
are for.
What do you think adding a prefix to all noisy neighbor related commands?
> +
> +* ``--nb-rnd-read=N``
> +
> + Set the number of reads to be done in noisy neighbour simulation memory buffer.
> + Only available with the noisy forwarding mode. The default value is 0.
> +
> +* ``--nb-rnd-write=N``
> +
> + Set the number of writes to be done in noisy neighbour simulation memory buffer.
> + Only available with the noisy forwarding mode. The default value is 0.
> +
> +* ``--nb-rnd-write=N``
> +
> + Set the number of r/w access to be done in noisy neighbour simulation memory buffer.
> + Only available with the noisy forwarding mode. The default value is 0.
<...>
next prev parent reply other threads:[~2018-04-13 13:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 11:37 [dpdk-dev] [PATCH v2 0/2] testpmd: simulating noisy host environment Jens Freimann
2018-04-13 11:37 ` [dpdk-dev] [PATCH v2 1/2] testpmd: add forwarding mode to simulate a noisy neighbour Jens Freimann
2018-06-14 11:26 ` Iremonger, Bernard
2018-04-13 11:37 ` [dpdk-dev] [PATCH v2 2/2] testpmd: update testpmd documentation to include noisy forwarding mode Jens Freimann
2018-04-13 13:19 ` Ferruh Yigit [this message]
2018-04-16 20:17 ` Jens Freimann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40abbbc6-911f-163c-a18f-2433e4cee48c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ailan@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jan.scheurich@ericsson.com \
--cc=jfreimann@redhat.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
--cc=vkaplans@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).