From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhang, AlvinX" <alvinx.zhang@intel.com>,
"Guo, Junfeng" <junfeng.guo@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
"Singh, Aman Deep" <aman.deep.singh@intel.com>
Subject: Re: [dpdk-dev] [PATCH v7] ethdev: add IPv4 and L4 checksum RSS offload types
Date: Mon, 6 Sep 2021 00:28:26 +0000 [thread overview]
Message-ID: <40f3d05eea4548ed87d49696feb9f23c@intel.com> (raw)
In-Reply-To: <20210831095255.21156-1-alvinx.zhang@intel.com>
> -----Original Message-----
> From: Zhang, AlvinX <alvinx.zhang@intel.com>
> Sent: Tuesday, August 31, 2021 5:53 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Guo, Junfeng
> <junfeng.guo@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>; Singh, Aman Deep
> <aman.deep.singh@intel.com>
> Subject: [PATCH v7] ethdev: add IPv4 and L4 checksum RSS offload types
>
> This patch defines new RSS offload types for IPv4 and
> L4(TCP/UDP/SCTP) checksum, which are required when users want to
> distribute packets based on the IPv4 or L4 checksum field.
>
> For example "flow create 0 ingress pattern eth / ipv4 / end actions rss types
> ipv4-chksum end queues end / end", this flow causes all matching packets to be
> distributed to queues on basis of IPv4 checksum.
>
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Acked-by: Aman Deep Singh <aman.deep.singh@intel.com>
> ---
>
> v6: rebase to eeedef70, update some note
> v7: fix code style issues
> ---
> app/test-pmd/cmdline.c | 4 +++-
> app/test-pmd/config.c | 2 ++
> doc/guides/rel_notes/release_21_11.rst | 5 +++++
> lib/ethdev/rte_ethdev.h | 24 ++++++++++++++++++++++++
> 4 files changed, 34 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> 82253bc..656a311 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -2252,6 +2252,8 @@ struct cmd_config_rss {
> rss_conf.rss_hf = ETH_RSS_ECPRI;
> else if (!strcmp(res->value, "mpls"))
> rss_conf.rss_hf = ETH_RSS_MPLS;
> + else if (!strcmp(res->value, "ipv4-chksum"))
> + rss_conf.rss_hf = ETH_RSS_IPV4_CHKSUM;
> else if (!strcmp(res->value, "none"))
> rss_conf.rss_hf = 0;
> else if (!strcmp(res->value, "level-default")) { @@ -2323,7 +2325,7 @@
> struct cmd_config_rss {
> .help_str = "port config all rss "
> "all|default|eth|vlan|ip|tcp|udp|sctp|ether|port|vxlan|geneve|"
>
> "nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|ecpri|mpls|none|level-default|"
> - "level-outer|level-inner|<flowtype_id>",
> + "level-outer|level-inner|ipv4-chksum|<flowtype_id>",
> .tokens = {
> (void *)&cmd_config_rss_port,
> (void *)&cmd_config_rss_keyword,
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> 31d8ba1..ece78f2 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -140,6 +140,8 @@
> { "gtpu", ETH_RSS_GTPU },
> { "ecpri", ETH_RSS_ECPRI },
> { "mpls", ETH_RSS_MPLS },
> + { "ipv4-chksum", ETH_RSS_IPV4_CHKSUM },
> + { "l4-chksum", ETH_RSS_L4_CHKSUM },
> { NULL, 0 },
> };
>
> diff --git a/doc/guides/rel_notes/release_21_11.rst
> b/doc/guides/rel_notes/release_21_11.rst
> index d707a55..fa29b13 100644
> --- a/doc/guides/rel_notes/release_21_11.rst
> +++ b/doc/guides/rel_notes/release_21_11.rst
> @@ -55,6 +55,11 @@ New Features
> Also, make sure to start the actual text at the margin.
> =======================================================
>
> +* **Add new RSS offload types for IPv4/L4 checksum in RSS flow.**
> +
> + Add macros ETH_RSS_IPV4_CHKSUM and ETH_RSS_L4_CHKSUM, now IPv4
> and
> + TCP/UDP/SCTP header checksum field can be used as input set for RSS.
> +
>
> Removed Items
> -------------
> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index
> d2b27c3..e6734df 100644
> --- a/lib/ethdev/rte_ethdev.h
> +++ b/lib/ethdev/rte_ethdev.h
> @@ -537,6 +537,30 @@ struct rte_eth_rss_conf {
> #define ETH_RSS_PPPOE (1ULL << 31)
> #define ETH_RSS_ECPRI (1ULL << 32)
> #define ETH_RSS_MPLS (1ULL << 33)
> +#define ETH_RSS_IPV4_CHKSUM (1ULL << 34)
> +
> +/**
> + * The ETH_RSS_L4_CHKSUM generally refers to a type of checksum field
> +for
> + * any L4 header, such as TCP, UDP and SCTP. It is similar to
> +ETH_RSS_PORT,
> + * it does not specify the type of L4 header.
> + * We use this macro to replace below macro for constricting the use of
> +RSS
> + * offload bits:
> + * ETH_RSS_IPV4_TCP_CHKSUM
> + * ETH_RSS_IPV4_UDP_CHKSUM
> + * ETH_RSS_IPV4_SCTP_CHKSUM
> + * ETH_RSS_IPV6_TCP_CHKSUM
> + * ETH_RSS_IPV6_UDP_CHKSUM
> + * ETH_RSS_IPV6_SCTP_CHKSUM
> + *
> + * Then how to use this macro? We can use it in RSS flow where the
> +pattern
> + * type will specify the L4 header type, for example "flow create 0
> +ingress \
> + * pattern eth / ipv4 / tcp / end actions rss types l4-chksum end
> +queues end \
> + * / end"
> + *
> + * For the case that checksum is not used in a UDP header, it takes the
> + * reserved value 0 as input for the hash function.
> + */
> +#define ETH_RSS_L4_CHKSUM (1ULL << 35)
>
> /*
> * We use the following macros to combine with above ETH_RSS_* for
> --
> 1.8.3.1
Reviewed-by: Qi Zhang <qi.z.zhang@intel.com>
next prev parent reply other threads:[~2021-09-06 0:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 3:12 [dpdk-dev] [PATCH] ethdev: add RSS offload type for L3 checksum Alvin Zhang
2021-06-03 7:14 ` Andrew Rybchenko
2021-06-03 7:28 ` Zhang, AlvinX
2021-06-03 8:03 ` [dpdk-dev] [PATCH v2] ethdev: add IPv4 checksum RSS offload type Alvin Zhang
2021-06-03 8:17 ` Andrew Rybchenko
2021-06-04 2:23 ` Zhang, AlvinX
2021-06-07 18:31 ` Ajit Khaparde
2021-06-15 8:19 ` [dpdk-dev] [PATCH v3] ethdev: add IPv4 and L4 checksum RSS offload types Alvin Zhang
2021-06-15 8:26 ` Jerin Jacob
2021-06-16 15:18 ` Zhang, Qi Z
2021-06-22 8:20 ` Singh, Aman Deep
2021-07-01 14:26 ` Andrew Rybchenko
2021-07-06 6:14 ` Zhang, AlvinX
2021-07-06 7:05 ` Zhang, AlvinX
2021-07-06 7:18 ` Zhang, Qi Z
2021-07-06 8:04 ` Andrew Rybchenko
2021-07-07 3:23 ` Zhang, Qi Z
2021-07-07 9:49 ` Andrew Rybchenko
2021-07-07 13:00 ` Zhang, Qi Z
2021-07-07 13:10 ` Andrew Rybchenko
2021-07-08 1:07 ` Zhang, Qi Z
2021-07-08 7:45 ` Andrew Rybchenko
2021-07-10 8:38 ` Thomas Monjalon
2021-07-13 1:13 ` [dpdk-dev] [PATCH v4] " Alvin Zhang
2021-07-13 7:54 ` Andrew Rybchenko
2021-07-13 9:38 ` Zhang, AlvinX
2021-07-13 10:24 ` Andrew Rybchenko
2021-07-14 2:38 ` Zhang, AlvinX
2021-08-18 2:32 ` [dpdk-dev] [PATCH v5] " Alvin Zhang
2021-08-29 12:07 ` Zhang, Qi Z
2021-08-31 9:44 ` [dpdk-dev] [PATCH v6] " Alvin Zhang
2021-08-31 9:52 ` [dpdk-dev] [PATCH v7] " Alvin Zhang
2021-09-06 0:28 ` Zhang, Qi Z [this message]
2021-09-14 14:00 ` Ferruh Yigit
2021-09-15 1:36 ` Zhang, AlvinX
2021-09-15 5:47 ` [dpdk-dev] [PATCH v8] " Alvin Zhang
2021-09-21 8:26 ` Ferruh Yigit
2021-09-28 13:09 ` Ferruh Yigit
2021-09-29 2:27 ` Zhang, AlvinX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40f3d05eea4548ed87d49696feb9f23c@intel.com \
--to=qi.z.zhang@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=alvinx.zhang@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=junfeng.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).