From: Thomas Monjalon <thomas@monjalon.net>
To: John Daley <johndale@cisco.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org,
Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/enic: fix multi-process operation
Date: Tue, 19 Sep 2017 00:25:25 +0200 [thread overview]
Message-ID: <4171800.AgbnscgTn2@xps> (raw)
In-Reply-To: <488ca130-7a8e-223f-5b9e-50bdab9b93f2@intel.com>
18/09/2017 23:27, Ferruh Yigit:
> On 9/11/2017 7:58 PM, John Daley wrote:
> > - Use rte_malloc() instead of malloc() for the per device 'vdev' structure
> > so that it can be shared across processes.
> > - Only initialize the device if the process type is RTE_PROC_PRIMARY
> > - Only allow the primary process to do queue setup, start/stop, promisc
> > allmulticast, mac add/del, mtu.
[...]
> > --- a/drivers/net/enic/enic_ethdev.c
> > +++ b/drivers/net/enic/enic_ethdev.c
> > @@ -142,6 +142,10 @@ enicpmd_dev_filter_ctrl(struct rte_eth_dev *dev,
> > static void enicpmd_dev_tx_queue_release(void *txq)
> > {
> > ENICPMD_FUNC_TRACE();
> > +
> > + if (rte_eal_process_type() != RTE_PROC_PRIMARY)
> > + return;
> > +
>
> Hi John,
>
> I am not sure about these updates. Agree that these functions should
> know process type, but all others PMDs don't do this.
>
> Added a few more people for comment, but as far I understand its
> application responsibility to NOT call these functions if it is
> secondary process.
>
> For device init/uninit, that is part of eal_init() and have to be called
> both for primary and secondary process and PMD needs to protect it, for
> other functions application's responsibility.
Yes for now it is the policy.
But it is a gray area and it could be clearer with my "ownership proposal":
http://dpdk.org/ml/archives/dev/2017-September/074656.html
A secondary process could manage the ports it owns.
Feel free to comment the proposal.
next prev parent reply other threads:[~2017-09-18 22:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 18:58 John Daley
2017-09-12 13:53 ` Aaron Conole
2017-09-18 21:27 ` Ferruh Yigit
2017-09-18 22:25 ` Thomas Monjalon [this message]
2017-09-19 5:31 ` John Daley (johndale)
2017-09-19 12:58 ` Ferruh Yigit
2017-09-22 13:02 ` John Daley (johndale)
2017-09-22 16:50 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4171800.AgbnscgTn2@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=johndale@cisco.com \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).