From: Thomas Monjalon <thomas@monjalon.net>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>
Cc: dev@dpdk.org, "Dumitrescu,
Cristian" <cristian.dumitrescu@intel.com>,
bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix freebsd build error
Date: Tue, 10 Apr 2018 14:19:38 +0200 [thread overview]
Message-ID: <4174344.PR9F3hB2no@xps> (raw)
In-Reply-To: <54CBAA185211B4429112C315DA58FF6D333361C4@IRSMSX101.ger.corp.intel.com>
10/04/2018 12:25, Singh, Jasvinder:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 10/04/2018 11:51, Jasvinder Singh:
> > > IP_Pipeline app is not supported in FreeBSD environment. Therefore,
> > > skip it while building the sample apps on FreeBSD.
> > [...]
> > > --- a/examples/ip_pipeline/Makefile
> > > +++ b/examples/ip_pipeline/Makefile
> > > @@ -67,6 +67,13 @@ RTE_TARGET ?= x86_64-native-linuxapp-gcc
> > >
> > > include $(RTE_SDK)/mk/rte.vars.mk
> > >
> > > +ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp")
> >
> > You can use CONFIG_RTE_EXEC_ENV_LINUXAPP
> >
> > > +$(info This application can only operate in a linuxapp environment, \
> > > +please change the definition of the RTE_TARGET environment variable)
> > > +all:
> > > +clean:
> > > +else
> >
> >
> > Copy of my previous comment:
> > "
> > It is not skipping the example, just throwing an error (which is needed).
> >
> > You should add a test in examples/Makefile to really skip it.
> > "
>
> In V2, we follow the same pattern as followed in other examples such as l3fwd-power, ethtool, etc.
A kind of counter example is:
ifeq ($(CONFIG_RTE_ARCH_X86_64),y)
DIRS-y += performance-thread
endif
But I get your point that it is done this way in several examples.
> If we put check in examples/Makefile, than how the situation is handled if someone tries to build ip_pipeline straight instead of building all examples.
My thought is that if you try to build explicitly this example on FreeBSD,
you should get an error.
> > In this v2, you replaced the error by an info message.
> > Error was better in my opinion.
I will get this v2 and not bother you more about that.
All examples could be fixed at once. Not sure it is worth though,
given this is the legacy build system.
next prev parent reply other threads:[~2018-04-10 12:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 12:06 [dpdk-dev] [PATCH] " Jasvinder Singh
2018-04-09 12:58 ` Dumitrescu, Cristian
2018-04-09 22:34 ` Thomas Monjalon
2018-04-10 9:53 ` Singh, Jasvinder
2018-04-10 9:51 ` [dpdk-dev] [PATCH v2] " Jasvinder Singh
2018-04-10 10:15 ` Thomas Monjalon
2018-04-10 10:25 ` Singh, Jasvinder
2018-04-10 12:19 ` Thomas Monjalon [this message]
2018-04-10 12:39 ` Bruce Richardson
2018-04-10 12:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4174344.PR9F3hB2no@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).